Skip to content

Incorrect typehint in turn_context.py #2146

@Nikita-Gz

Description

@Nikita-Gz

Describe the bug

send_activity function in botbuilder/core/turn_context.py has a type hint that implies that this function always returns ResourceResponse. That is not true, as it can also return None. This may lead other programmers, like me, to assume that there is never a need to check for None output here.

Expected behavior

Type hint must be adjusted to include None

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugIndicates an unexpected problem or an unintended behavior.needs-triageThe issue has just been created and it has not been reviewed by the team.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions