Skip to content

Commit 947ff5f

Browse files
authored
Merge pull request #1178 from microsoft/axsuarez/slack-docs-fix
Adding dependencies to setup.py
2 parents efa5e36 + d1edfae commit 947ff5f

File tree

4 files changed

+10
-10
lines changed

4 files changed

+10
-10
lines changed

libraries/botbuilder-adapters-slack/botbuilder/adapters/slack/slack_client.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,13 @@
1010
import aiohttp
1111
from aiohttp.web_request import Request
1212

13+
from slack.web.client import WebClient
14+
from slack.web.slack_response import SlackResponse
15+
1316
from botbuilder.schema import Activity
1417
from botbuilder.adapters.slack import SlackAdapterOptions
1518
from botbuilder.adapters.slack.slack_message import SlackMessage
1619

17-
from slack.web.client import WebClient
18-
from slack.web.slack_response import SlackResponse
19-
2020
POST_MESSAGE_URL = "https://slack.com/api/chat.postMessage"
2121
POST_EPHEMERAL_MESSAGE_URL = "https://slack.com/api/chat.postEphemeral"
2222

libraries/botbuilder-adapters-slack/botbuilder/adapters/slack/slack_helper.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,15 +7,15 @@
77
from aiohttp.web_request import Request
88
from aiohttp.web_response import Response
99

10+
from slack.web.classes.attachments import Attachment
11+
1012
from botbuilder.schema import (
1113
Activity,
1214
ConversationAccount,
1315
ChannelAccount,
1416
ActivityTypes,
1517
)
1618

17-
from slack.web.classes.attachments import Attachment
18-
1919
from .slack_message import SlackMessage
2020
from .slack_client import SlackClient
2121
from .slack_event import SlackEvent
@@ -53,7 +53,7 @@ def activity_to_slack(activity: Activity) -> SlackMessage:
5353
message.blocks = att.content
5454
else:
5555
new_attachment = Attachment(
56-
author_name=att.name, thumb_url=att.thumbnail_url,
56+
author_name=att.name, thumb_url=att.thumbnail_url, text="",
5757
)
5858
attachments.append(new_attachment)
5959

libraries/botbuilder-adapters-slack/botbuilder/adapters/slack/slack_payload.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,8 @@
22
# Licensed under the MIT License.
33

44
from typing import Optional, List
5-
6-
from botbuilder.adapters.slack.slack_message import SlackMessage
7-
85
from slack.web.classes.actions import Action
6+
from botbuilder.adapters.slack.slack_message import SlackMessage
97

108

119
class SlackPayload:

libraries/botbuilder-adapters-slack/setup.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@
88
"botbuilder-schema==4.10.0",
99
"botframework-connector==4.10.0",
1010
"botbuilder-core==4.10.0",
11+
"pyslack",
12+
"slackclient",
1113
]
1214

1315
TEST_REQUIRES = ["aiounittest==1.3.0"]
@@ -32,7 +34,7 @@
3234
long_description=long_description,
3335
long_description_content_type="text/x-rst",
3436
license=package_info["__license__"],
35-
packages=["botbuilder.adapters", "botbuilder.adapters.slack",],
37+
packages=["botbuilder.adapters.slack"],
3638
install_requires=REQUIRES + TEST_REQUIRES,
3739
tests_require=TEST_REQUIRES,
3840
include_package_data=True,

0 commit comments

Comments
 (0)