Skip to content

Commit 4a2ecef

Browse files
Virtual-Joshjohnataylor
authored andcommitted
updating create conversation to take conversation params (#496)
* updating create conversation to take conversation params * updating attributes on activity
1 parent 8562148 commit 4a2ecef

File tree

1 file changed

+11
-3
lines changed

1 file changed

+11
-3
lines changed

libraries/botbuilder-core/botbuilder/core/bot_framework_adapter.py

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
from msrest.serialization import Model
1010
from botbuilder.schema import (
1111
Activity,
12+
ActivityTypes,
1213
ConversationAccount,
1314
ConversationParameters,
1415
ConversationReference,
@@ -172,6 +173,7 @@ async def create_conversation(
172173
self,
173174
reference: ConversationReference,
174175
logic: Callable[[TurnContext], Awaitable] = None,
176+
conversation_parameters: ConversationParameters = None,
175177
):
176178
"""
177179
Starts a new conversation with a user. This is typically used to Direct Message (DM) a member
@@ -187,8 +189,12 @@ async def create_conversation(
187189
)
188190

189191
# Create conversation
190-
parameters = ConversationParameters(
191-
bot=reference.bot, members=[reference.user], is_group=False
192+
parameters = (
193+
conversation_parameters
194+
if conversation_parameters
195+
else ConversationParameters(
196+
bot=reference.bot, members=[reference.user], is_group=False
197+
)
192198
)
193199
client = await self.create_connector_client(reference.service_url)
194200

@@ -206,7 +212,9 @@ async def create_conversation(
206212
parameters
207213
)
208214
request = TurnContext.apply_conversation_reference(
209-
Activity(), reference, is_incoming=True
215+
Activity(type=ActivityTypes.event, name="CreateConversation"),
216+
reference,
217+
is_incoming=True,
210218
)
211219
request.conversation = ConversationAccount(
212220
id=resource_response.id, tenant_id=parameters.tenant_id

0 commit comments

Comments
 (0)