OAuthPrompt timeout applies to all auth related events and invokes. #4399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomlm
reviewed
Aug 6, 2020
cleemullins
reviewed
Aug 6, 2020
cleemullins
approved these changes
Aug 7, 2020
|
@carlosscastro We beleive this is good to merge. Tom has looked at it, and Eric confident. Just because OAuth and SSO are such nuanced areas, can you take a quick peek before we merge? |
| || IsTokenResponseEvent(dc.Context) | ||
| || IsTeamsVerificationInvoke(dc.Context) | ||
| || IsTokenExchangeRequestInvoke(dc.Context); | ||
| var hasTimedOut = isTimeoutActivityType && DateTime.Compare(DateTime.Now, expires) > 0; |
There was a problem hiding this comment.
Also, it's more readable if you compare dates with the operator IMO instead of DateTime.Compare, i.e. date1 > date2
carlosscastro
approved these changes
Aug 7, 2020
This was referenced Aug 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3627
This PR also prioritizes the timeout check before RecognizeTokenAsync, since RecognizeTokenAsync has side affects.