Do not emit references in generated declaration files if the --noresolve flag was set #599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lve flag was set. This fixes a crash in the compiler when generating declarations with /// reference and noResolve
src/compiler/emitter.ts
Outdated
Member
There was a problem hiding this comment.
Why? If it is not noResolve, the reference files should always be searched. and found
Contributor
Author
There was a problem hiding this comment.
this is a defensive check, in case the caller ignores resolution errors.
Member
|
👍 |
mhegazy
added a commit
that referenced
this pull request
Sep 5, 2014
Do not emit references in generated declaration files if the --noresolve flag was set
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a crash in the compiler when generating declarations with /// reference and noResolve