Skip to content

Move auto-generated identifier info into separate object #51900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 15, 2022
Merged

Move auto-generated identifier info into separate object #51900

merged 1 commit into from
Dec 15, 2022

Conversation

@rbuckton
Copy link
Contributor

@rbuckton rbuckton commented Dec 15, 2022

This is another perf-related PR attempting to further stabilize the shape of Identifier.

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Dec 15, 2022
@rbuckton
Copy link
Contributor Author

rbuckton commented Dec 15, 2022

@typescript-bot perf test

@typescript-bot
Copy link
Collaborator

typescript-bot commented Dec 15, 2022 •
edited
Loading

Heya @rbuckton, I've started to run the perf test suite on this PR at 4e45af6. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Dec 15, 2022

@rbuckton
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..51900
Metric main 51900 Delta Best Worst
Angular - node (v18.10.0, x64)
Memory used 364,518k (± 0.02%) 364,596k (± 0.01%) +78k (+ 0.02%) 364,476k 364,680k
Parse Time 1.57s (± 0.67%) 1.56s (± 0.77%) -0.01s (- 0.45%) 1.54s 1.59s
Bind Time 0.55s (± 0.89%) 0.55s (± 1.12%) -0.00s (- 0.54%) 0.54s 0.56s
Check Time 3.91s (± 0.56%) 3.89s (± 0.71%) -0.03s (- 0.64%) 3.82s 3.94s
Emit Time 3.91s (± 0.99%) 3.87s (± 0.63%) -0.04s (- 0.97%) 3.82s 3.92s
Total Time 9.94s (± 0.49%) 9.87s (± 0.40%) -0.07s (- 0.73%) 9.78s 9.93s
Compiler-Unions - node (v18.10.0, x64)
Memory used 198,517k (± 0.98%) 199,115k (± 1.05%) +597k (+ 0.30%) 196,777k 202,577k
Parse Time 0.62s (± 0.93%) 0.62s (± 0.94%) -0.00s (- 0.48%) 0.61s 0.63s
Bind Time 0.35s (± 1.58%) 0.35s (± 1.27%) -0.00s (- 0.00%) 0.34s 0.36s
Check Time 4.94s (± 0.95%) 4.93s (± 0.43%) -0.01s (- 0.20%) 4.89s 4.99s
Emit Time 1.46s (± 1.03%) 1.44s (± 1.04%) -0.02s (- 1.37%) 1.41s 1.48s
Total Time 7.38s (± 0.74%) 7.34s (± 0.28%) -0.04s (- 0.49%) 7.29s 7.39s
Monaco - node (v18.10.0, x64)
Memory used 347,289k (± 0.02%) 347,279k (± 0.02%) -10k (- 0.00%) 347,143k 347,413k
Parse Time 1.18s (± 1.03%) 1.18s (± 0.71%) 0.00s ( 0.00%) 1.16s 1.20s
Bind Time 0.50s (± 1.11%) 0.50s (± 1.35%) +0.00s (+ 0.40%) 0.49s 0.52s
Check Time 3.64s (± 0.50%) 3.67s (± 0.78%) +0.02s (+ 0.63%) 3.61s 3.72s
Emit Time 2.05s (± 0.85%) 2.04s (± 0.73%) -0.01s (- 0.44%) 2.01s 2.07s
Total Time 7.37s (± 0.56%) 7.38s (± 0.53%) +0.02s (+ 0.20%) 7.32s 7.49s
TFS - node (v18.10.0, x64)
Memory used 305,780k (± 0.25%) 305,636k (± 0.24%) -144k (- 0.05%) 304,805k 307,218k
Parse Time 0.96s (± 0.52%) 0.95s (± 1.06%) -0.00s (- 0.10%) 0.94s 0.99s
Bind Time 0.55s (± 5.72%) 0.54s (± 7.65%) -0.01s (- 2.52%) 0.45s 0.59s
Check Time 3.39s (± 0.48%) 3.39s (± 0.51%) -0.00s (- 0.15%) 3.36s 3.43s
Emit Time 2.02s (± 0.89%) 2.01s (± 1.08%) -0.01s (- 0.55%) 1.96s 2.06s
Total Time 6.92s (± 0.75%) 6.89s (± 0.74%) -0.03s (- 0.40%) 6.77s 6.98s
material-ui - node (v18.10.0, x64)
Memory used 451,775k (± 0.02%) 451,775k (± 0.01%) -0k (- 0.00%) 451,620k 451,964k
Parse Time 1.38s (± 0.91%) 1.37s (± 0.97%) -0.00s (- 0.07%) 1.34s 1.41s
Bind Time 0.41s (± 1.26%) 0.41s (± 1.26%) 0.00s ( 0.00%) 0.40s 0.42s
Check Time 10.13s (± 0.69%) 10.17s (± 1.04%) +0.03s (+ 0.31%) 9.96s 10.37s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 11.92s (± 0.63%) 11.95s (± 0.97%) +0.03s (+ 0.24%) 11.74s 12.18s
xstate - node (v18.10.0, x64)
Memory used 553,506k (± 0.01%) 553,499k (± 0.01%) -7k (- 0.00%) 553,409k 553,618k
Parse Time 1.91s (± 0.63%) 1.91s (± 0.26%) -0.00s (- 0.10%) 1.89s 1.91s
Bind Time 0.71s (± 2.87%) 0.71s (± 3.66%) +0.00s (+ 0.28%) 0.67s 0.77s
Check Time 1.02s (± 0.55%) 1.01s (± 0.61%) -0.01s (- 0.88%) 1.00s 1.03s
Emit Time 0.05s (± 0.00%) 0.05s (± 0.00%) 0.00s ( 0.00%) 0.05s 0.05s
Total Time 3.69s (± 0.76%) 3.68s (± 0.83%) -0.01s (- 0.16%) 3.62s 3.75s
Angular - node (v16.17.1, x64)
Memory used 363,951k (± 0.02%) 363,920k (± 0.01%) -31k (- 0.01%) 363,755k 363,967k
Parse Time 1.91s (± 0.29%) 1.91s (± 0.82%) +0.01s (+ 0.31%) 1.88s 1.95s
Bind Time 0.66s (± 0.50%) 0.66s (± 0.79%) +0.00s (+ 0.15%) 0.65s 0.67s
Check Time 5.02s (± 0.53%) 4.99s (± 0.64%) -0.02s (- 0.46%) 4.92s 5.05s
Emit Time 4.68s (± 0.97%) 4.65s (± 1.01%) -0.02s (- 0.51%) 4.57s 4.78s
Total Time 12.26s (± 0.56%) 12.22s (± 0.67%) -0.04s (- 0.37%) 12.03s 12.37s
Compiler-Unions - node (v16.17.1, x64)
Memory used 200,877k (± 0.57%) 200,563k (± 0.62%) -314k (- 0.16%) 198,518k 202,132k
Parse Time 0.80s (± 0.77%) 0.80s (± 0.84%) -0.00s (- 0.25%) 0.78s 0.81s
Bind Time 0.44s (± 0.91%) 0.44s (± 0.51%) 0.00s ( 0.00%) 0.44s 0.45s
Check Time 5.92s (± 0.70%) 5.87s (± 0.96%) -0.05s (- 0.88%) 5.75s 6.01s
Emit Time 1.79s (± 0.87%) 1.81s (± 1.42%) +0.02s (+ 0.89%) 1.75s 1.86s
Total Time 8.96s (± 0.47%) 8.92s (± 0.61%) -0.04s (- 0.44%) 8.82s 9.07s
Monaco - node (v16.17.1, x64)
Memory used 346,553k (± 0.01%) 346,572k (± 0.02%) +19k (+ 0.01%) 346,371k 346,699k
Parse Time 1.43s (± 0.71%) 1.42s (± 0.79%) -0.01s (- 0.70%) 1.40s 1.45s
Bind Time 0.61s (± 0.85%) 0.61s (± 0.49%) -0.00s (- 0.16%) 0.60s 0.61s
Check Time 4.63s (± 0.37%) 4.63s (± 0.60%) +0.00s (+ 0.00%) 4.57s 4.71s
Emit Time 2.49s (± 0.79%) 2.45s (± 0.84%) -0.04s (- 1.69%) 2.42s 2.51s
Total Time 9.16s (± 0.22%) 9.10s (± 0.56%) -0.05s (- 0.57%) 9.01s 9.23s
TFS - node (v16.17.1, x64)
Memory used 304,201k (± 0.03%) 304,288k (± 0.02%) +87k (+ 0.03%) 304,081k 304,392k
Parse Time 1.19s (± 1.61%) 1.19s (± 2.46%) +0.00s (+ 0.25%) 1.15s 1.29s
Bind Time 0.57s (± 0.86%) 0.59s (± 4.69%) +0.02s (+ 3.14%) 0.56s 0.70s
Check Time 4.34s (± 0.23%) 4.34s (± 0.34%) +0.01s (+ 0.16%) 4.32s 4.38s
Emit Time 2.52s (± 1.48%) 2.49s (± 1.83%) -0.02s (- 0.91%) 2.40s 2.61s
Total Time 8.62s (± 0.49%) 8.62s (± 0.84%) +0.01s (+ 0.06%) 8.48s 8.84s
material-ui - node (v16.17.1, x64)
Memory used 451,094k (± 0.01%) 451,127k (± 0.02%) +33k (+ 0.01%) 450,993k 451,276k
Parse Time 1.67s (± 0.74%) 1.67s (± 0.56%) +0.00s (+ 0.18%) 1.65s 1.69s
Bind Time 0.50s (± 1.29%) 0.50s (± 0.80%) -0.00s (- 0.20%) 0.49s 0.51s
Check Time 11.71s (± 0.73%) 11.67s (± 0.61%) -0.03s (- 0.29%) 11.53s 11.81s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 13.88s (± 0.67%) 13.85s (± 0.48%) -0.03s (- 0.20%) 13.71s 14.00s
xstate - node (v16.17.1, x64)
Memory used 551,092k (± 0.00%) 551,097k (± 0.00%) +5k (+ 0.00%) 551,047k 551,156k
Parse Time 2.31s (± 0.70%) 2.29s (± 0.60%) -0.02s (- 0.95%) 2.26s 2.32s
Bind Time 0.85s (± 2.30%) 0.84s (± 2.86%) -0.01s (- 0.94%) 0.80s 0.90s
Check Time 1.35s (± 0.45%) 1.34s (± 0.63%) -0.01s (- 0.45%) 1.32s 1.36s
Emit Time 0.06s (± 0.00%) 0.06s (± 0.00%) 0.00s ( 0.00%) 0.06s 0.06s
Total Time 4.57s (± 0.48%) 4.53s (± 0.71%) -0.03s (- 0.74%) 4.47s 4.61s
Angular - node (v14.15.1, x64)
Memory used 357,651k (± 0.00%) 357,630k (± 0.01%) -21k (- 0.01%) 357,586k 357,695k
Parse Time 2.05s (± 0.63%) 2.04s (± 0.42%) -0.02s (- 0.83%) 2.02s 2.05s
Bind Time 0.71s (± 0.51%) 0.71s (± 0.94%) -0.00s (- 0.14%) 0.70s 0.73s
Check Time 5.35s (± 0.61%) 5.34s (± 0.81%) -0.01s (- 0.17%) 5.27s 5.46s
Emit Time 4.80s (± 0.43%) 4.77s (± 0.87%) -0.03s (- 0.71%) 4.70s 4.88s
Total Time 12.92s (± 0.38%) 12.86s (± 0.49%) -0.06s (- 0.46%) 12.75s 12.99s
Compiler-Unions - node (v14.15.1, x64)
Memory used 196,234k (± 0.51%) 195,219k (± 0.64%) -1,015k (- 0.52%) 193,515k 196,940k
Parse Time 0.90s (± 0.69%) 0.90s (± 0.64%) +0.00s (+ 0.11%) 0.89s 0.91s
Bind Time 0.47s (± 0.94%) 0.47s (± 0.94%) -0.00s (- 0.00%) 0.47s 0.49s
Check Time 6.17s (± 0.75%) 6.13s (± 0.64%) -0.04s (- 0.66%) 6.06s 6.24s
Emit Time 1.92s (± 0.72%) 1.90s (± 0.96%) -0.02s (- 1.04%) 1.86s 1.94s
Total Time 9.46s (± 0.58%) 9.41s (± 0.53%) -0.06s (- 0.62%) 9.31s 9.54s
Monaco - node (v14.15.1, x64)
Memory used 341,554k (± 0.00%) 341,517k (± 0.01%) -37k (- 0.01%) 341,481k 341,590k
Parse Time 1.58s (± 0.55%) 1.57s (± 0.72%) -0.01s (- 0.70%) 1.55s 1.60s
Bind Time 0.65s (± 0.69%) 0.65s (± 0.62%) +0.00s (+ 0.15%) 0.64s 0.66s
Check Time 4.93s (± 0.71%) 4.91s (± 0.39%) -0.02s (- 0.43%) 4.86s 4.95s
Emit Time 2.58s (± 0.76%) 2.55s (± 0.65%) -0.03s (- 1.01%) 2.52s 2.60s
Total Time 9.74s (± 0.47%) 9.68s (± 0.34%) -0.06s (- 0.60%) 9.62s 9.78s
TFS - node (v14.15.1, x64)
Memory used 301,375k (± 0.01%) 301,374k (± 0.00%) -1k (- 0.00%) 301,354k 301,397k
Parse Time 1.33s (± 1.51%) 1.33s (± 1.66%) -0.01s (- 0.38%) 1.29s 1.38s
Bind Time 0.60s (± 0.56%) 0.60s (± 0.79%) 0.00s ( 0.00%) 0.59s 0.61s
Check Time 4.59s (± 0.51%) 4.62s (± 0.53%) +0.03s (+ 0.63%) 4.58s 4.71s
Emit Time 2.76s (± 0.97%) 2.77s (± 0.65%) +0.00s (+ 0.18%) 2.73s 2.80s
Total Time 9.29s (± 0.48%) 9.32s (± 0.37%) +0.03s (+ 0.31%) 9.26s 9.41s
material-ui - node (v14.15.1, x64)
Memory used 446,778k (± 0.01%) 446,780k (± 0.01%) +3k (+ 0.00%) 446,679k 446,817k
Parse Time 1.88s (± 0.18%) 1.87s (± 0.47%) -0.00s (- 0.21%) 1.86s 1.90s
Bind Time 0.54s (± 0.55%) 0.54s (± 0.68%) -0.00s (- 0.37%) 0.53s 0.54s
Check Time 11.98s (± 0.42%) 11.97s (± 0.54%) -0.01s (- 0.07%) 11.86s 12.14s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 14.40s (± 0.34%) 14.38s (± 0.50%) -0.01s (- 0.08%) 14.26s 14.59s
xstate - node (v14.15.1, x64)
Memory used 539,735k (± 0.01%) 539,741k (± 0.01%) +6k (+ 0.00%) 539,595k 539,914k
Parse Time 2.65s (± 0.87%) 2.64s (± 0.69%) -0.00s (- 0.11%) 2.61s 2.68s
Bind Time 0.82s (± 0.49%) 0.82s (± 0.68%) -0.00s (- 0.12%) 0.81s 0.83s
Check Time 1.44s (± 0.50%) 1.43s (± 0.56%) -0.01s (- 0.69%) 1.41s 1.45s
Emit Time 0.07s (± 0.00%) 0.07s (± 0.00%) 0.00s ( 0.00%) 0.07s 0.07s
Total Time 4.98s (± 0.46%) 4.97s (± 0.32%) -0.02s (- 0.32%) 4.93s 5.01s
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-131-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v18.10.0, x64)
  • Angular - node (v16.17.1, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v18.10.0, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v18.10.0, x64)
  • Monaco - node (v16.17.1, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v18.10.0, x64)
  • TFS - node (v16.17.1, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v18.10.0, x64)
  • material-ui - node (v16.17.1, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v18.10.0, x64)
  • xstate - node (v16.17.1, x64)
  • xstate - node (v14.15.1, x64)
Benchmark Name Iterations
Current 51900 10
Baseline main 10

TSServer

Comparison Report - main..51900
Metric main 51900 Delta Best Worst
Compiler-UnionsTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 1,062ms (± 0.49%) 1,067ms (± 0.49%) +5ms (+ 0.46%) 1,053ms 1,078ms
Req 2 - geterr 2,548ms (± 0.63%) 2,549ms (± 0.95%) +1ms (+ 0.02%) 2,515ms 2,608ms
Req 3 - references 165ms (± 1.33%) 164ms (± 0.50%) -1ms (- 0.79%) 162ms 166ms
Req 4 - navto 143ms (± 0.80%) 143ms (± 1.10%) -0ms (- 0.28%) 140ms 147ms
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) 0 ( 0.00%) 1,356 1,356
Req 5 - completionInfo 53ms (± 8.43%) 54ms (± 7.88%) +1ms (+ 2.45%) 49ms 63ms
CompilerTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 1,138ms (± 0.53%) 1,134ms (± 0.65%) -3ms (- 0.30%) 1,122ms 1,157ms
Req 2 - geterr 1,565ms (± 0.71%) 1,577ms (± 0.55%) +12ms (+ 0.79%) 1,561ms 1,595ms
Req 3 - references 172ms (± 0.51%) 172ms (± 1.31%) +0ms (+ 0.12%) 170ms 181ms
Req 4 - navto 152ms (± 0.73%) 153ms (± 0.69%) +0ms (+ 0.20%) 150ms 155ms
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) 0 ( 0.00%) 1,518 1,518
Req 5 - completionInfo 53ms (± 1.17%) 53ms (± 1.40%) +0ms (+ 0.19%) 52ms 55ms
xstateTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 1,541ms (± 0.80%) 1,530ms (± 0.75%) -12ms (- 0.77%) 1,513ms 1,570ms
Req 2 - geterr 544ms (± 1.03%) 543ms (± 1.35%) -1ms (- 0.20%) 532ms 561ms
Req 3 - references 56ms (± 2.74%) 59ms (± 2.94%) +3ms (+ 4.63%) 55ms 62ms
Req 4 - navto 192ms (± 0.65%) 193ms (± 1.17%) +1ms (+ 0.31%) 190ms 199ms
Req 5 - completionInfo count 3,154 (± 0.00%) 3,154 (± 0.00%) 0 ( 0.00%) 3,154 3,154
Req 5 - completionInfo 213ms (± 1.38%) 216ms (± 1.86%) +2ms (+ 1.12%) 207ms 225ms
Compiler-UnionsTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 1,330ms (± 0.57%) 1,315ms (± 0.46%) -15ms (- 1.14%) 1,302ms 1,333ms
Req 2 - geterr 3,162ms (± 0.75%) 3,137ms (± 0.66%) -25ms (- 0.79%) 3,093ms 3,177ms
Req 3 - references 195ms (± 0.35%) 191ms (± 0.63%) -3ms (- 1.70%) 189ms 194ms
Req 4 - navto 156ms (± 1.18%) 155ms (± 0.99%) -1ms (- 0.83%) 152ms 158ms
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) 0 ( 0.00%) 1,356 1,356
Req 5 - completionInfo 58ms (± 1.56%) 57ms (± 1.75%) -1ms (- 1.89%) 55ms 59ms
CompilerTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 1,415ms (± 0.75%) 1,407ms (± 0.58%) -7ms (- 0.52%) 1,388ms 1,422ms
Req 2 - geterr 2,070ms (± 0.58%) 2,073ms (± 0.54%) +3ms (+ 0.16%) 2,047ms 2,106ms
Req 3 - references 201ms (± 0.47%) 201ms (± 0.90%) +1ms (+ 0.25%) 197ms 204ms
Req 4 - navto 168ms (± 0.80%) 167ms (± 1.02%) -1ms (- 0.77%) 163ms 171ms
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) 0 ( 0.00%) 1,518 1,518
Req 5 - completionInfo 57ms (± 0.98%) 56ms (± 1.05%) -0ms (- 0.70%) 55ms 58ms
xstateTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 1,857ms (± 0.52%) 1,854ms (± 0.55%) -3ms (- 0.16%) 1,830ms 1,876ms
Req 2 - geterr 697ms (± 1.07%) 689ms (± 0.75%) -7ms (- 1.02%) 682ms 702ms
Req 3 - references 66ms (± 2.07%) 66ms (± 1.14%) -1ms (- 0.90%) 64ms 67ms
Req 4 - navto 198ms (± 0.96%) 196ms (± 0.95%) -2ms (- 0.91%) 194ms 203ms
Req 5 - completionInfo count 3,154 (± 0.00%) 3,154 (± 0.00%) 0 ( 0.00%) 3,154 3,154
Req 5 - completionInfo 258ms (± 1.75%) 257ms (± 1.56%) -1ms (- 0.50%) 251ms 267ms
Compiler-UnionsTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 1,476ms (± 0.38%) 1,476ms (± 0.40%) -1ms (- 0.05%) 1,465ms 1,490ms
Req 2 - geterr 3,358ms (± 0.71%) 3,357ms (± 0.71%) -1ms (- 0.04%) 3,313ms 3,409ms
Req 3 - references 209ms (± 0.79%) 208ms (± 0.57%) -1ms (- 0.48%) 206ms 211ms
Req 4 - navto 169ms (± 0.59%) 170ms (± 0.76%) +1ms (+ 0.41%) 168ms 173ms
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) 0 ( 0.00%) 1,356 1,356
Req 5 - completionInfo 58ms (± 2.07%) 58ms (± 0.96%) -1ms (- 1.03%) 57ms 59ms
CompilerTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 1,571ms (± 0.51%) 1,571ms (± 0.27%) -0ms (- 0.02%) 1,563ms 1,582ms
Req 2 - geterr 2,227ms (± 0.43%) 2,225ms (± 0.57%) -2ms (- 0.10%) 2,194ms 2,253ms
Req 3 - references 219ms (± 1.09%) 221ms (± 1.74%) +2ms (+ 0.78%) 215ms 231ms
Req 4 - navto 179ms (± 0.86%) 179ms (± 0.56%) -0ms (- 0.17%) 177ms 181ms
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) 0 ( 0.00%) 1,518 1,518
Req 5 - completionInfo 61ms (± 5.88%) 59ms (± 3.54%) -2ms (- 2.63%) 56ms 65ms
xstateTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 1,992ms (± 0.49%) 1,988ms (± 0.44%) -4ms (- 0.22%) 1,972ms 2,008ms
Req 2 - geterr 740ms (± 0.46%) 737ms (± 0.17%) -3ms (- 0.39%) 734ms 739ms
Req 3 - references 71ms (± 0.99%) 71ms (± 1.25%) -0ms (- 0.28%) 70ms 73ms
Req 4 - navto 218ms (± 0.53%) 217ms (± 0.54%) -1ms (- 0.51%) 214ms 220ms
Req 5 - completionInfo count 3,154 (± 0.00%) 3,154 (± 0.00%) 0 ( 0.00%) 3,154 3,154
Req 5 - completionInfo 273ms (± 0.47%) 273ms (± 0.44%) -0ms (- 0.07%) 271ms 277ms
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-131-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Compiler-UnionsTSServer - node (v18.10.0, x64)
  • Compiler-UnionsTSServer - node (v16.17.1, x64)
  • Compiler-UnionsTSServer - node (v14.15.1, x64)
  • CompilerTSServer - node (v18.10.0, x64)
  • CompilerTSServer - node (v16.17.1, x64)
  • CompilerTSServer - node (v14.15.1, x64)
  • xstateTSServer - node (v18.10.0, x64)
  • xstateTSServer - node (v16.17.1, x64)
  • xstateTSServer - node (v14.15.1, x64)
Benchmark Name Iterations
Current 51900 10
Baseline main 10

Startup

Comparison Report - main..51900
Metric main 51900 Delta Best Worst
tsc-startup - node (v16.17.1, x64)
Execution time 119.43ms (± 0.51%) 118.32ms (± 0.35%) -1.11ms (- 0.93%) 116.11ms 123.09ms
tsserver-startup - node (v16.17.1, x64)
Execution time 200.63ms (± 0.41%) 199.10ms (± 0.29%) -1.52ms (- 0.76%) 196.20ms 207.20ms
tsserverlibrary-startup - node (v16.17.1, x64)
Execution time 194.73ms (± 0.41%) 194.07ms (± 0.38%) -0.67ms (- 0.34%) 190.42ms 202.42ms
typescript-startup - node (v16.17.1, x64)
Execution time 179.29ms (± 0.39%) 179.59ms (± 0.38%) +0.29ms (+ 0.16%) 176.71ms 186.53ms
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-131-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • tsc-startup - node (v16.17.1, x64)
  • tsserver-startup - node (v16.17.1, x64)
  • tsserverlibrary-startup - node (v16.17.1, x64)
  • typescript-startup - node (v16.17.1, x64)
Benchmark Name Iterations
Current 51900 10
Baseline main 10

Developer Information:

Download Benchmark

@rbuckton rbuckton force-pushed the separate-autogenerate branch from 4e45af6 to c69c84e Compare December 15, 2022 01:08
@rbuckton
Copy link
Contributor Author

rbuckton commented Dec 15, 2022

Not a huge win, but probably still a worthwhile change.

@rbuckton rbuckton marked this pull request as ready for review December 15, 2022 01:08
jakebailey
jakebailey reviewed Dec 15, 2022
View reviewed changes
@rbuckton rbuckton force-pushed the separate-autogenerate branch from c69c84e to 69c2f4c Compare December 15, 2022 15:42
@rbuckton rbuckton merged commit 44e8244 into main Dec 15, 2022
@rbuckton rbuckton deleted the separate-autogenerate branch December 15, 2022 18:59
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jakebailey jakebailey jakebailey approved these changes

@sandersn sandersn Awaiting requested review from sandersn

Assignees

@rbuckton rbuckton

Labels

Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rbuckton @typescript-bot @jakebailey