To handle d.ts emit errors that could affect other files, in incremental mode use d.ts emit text + diagnostics as signature of the file #49543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… which results in incorrect incremental behaviour
…can be more accurate for detecting changes to file that could affect other files Fixes #49527
typescript-bot
added
Author: Team
For Uncommitted Bug
Member
Author
amcasey
approved these changes
Jun 24, 2022
Member
amcasey
left a comment
amcasey
left a comment
There was a problem hiding this comment.
Seems sensible, but I have some questions about potential optimizations.
Do not serialize file name if error is in same file we are emitting. this should avoid having to do file path computation in most cases. Locations are start and length instead of line and character. Do not use any indents
Member
Author
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use to consider only d.ts emit text as file signature of file which meant if d.ts emit changed we would update other files that reference the file. But d.ts emit can have errors resulting in same .d.ts emit but impacting the other files. So now we consider d.ts file text + diagnostics as a signature of the file
Fixes #49527