goToDefinition: Don't add duplicate definitions for PropertyAssignment and ArrowFunction at m: () => {}
#24995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t and ArrowFunction at `m: () => {}`
mhegazy
reviewed
Jun 21, 2018
src/services/goToDefinition.ts
Outdated
| function symbolMatchesSignature(s: Symbol, calledDeclaration: SignatureDeclaration) { | ||
| return s === calledDeclaration.symbol || s === calledDeclaration.symbol.parent || | ||
| isVariableDeclaration(calledDeclaration.parent) && s === calledDeclaration.parent.symbol; | ||
| (isVariableDeclaration(calledDeclaration.parent) || isPropertyAssignment(calledDeclaration.parent)) && s === calledDeclaration.parent.symbol; |
Contributor
There was a problem hiding this comment.
would not it be better to check if the parent is callExpression or newExpression?
Author
|
Test failure fixed by #25199 |
ghost
merged commit 
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sequel to #24863
Fixes an issue identified in #24809