From f63a1a97efd6c44cd723a80a11d3dac087c70ea3 Mon Sep 17 00:00:00 2001 From: Andy Hanson Date: Wed, 1 Nov 2017 13:04:05 -0700 Subject: [PATCH 1/3] Remember to provide source for completionDetails from client.ts --- src/server/client.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/server/client.ts b/src/server/client.ts index bf46301ff86cb..727bfbf29dd33 100644 --- a/src/server/client.ts +++ b/src/server/client.ts @@ -192,8 +192,8 @@ namespace ts.server { }; } - getCompletionEntryDetails(fileName: string, position: number, entryName: string): CompletionEntryDetails { - const args: protocol.CompletionDetailsRequestArgs = { ...this.createFileLocationRequestArgs(fileName, position), entryNames: [entryName] }; + getCompletionEntryDetails(fileName: string, position: number, entryName: string, source: string | undefined): CompletionEntryDetails { + const args: protocol.CompletionDetailsRequestArgs = { ...this.createFileLocationRequestArgs(fileName, position), entryNames: [{ name: entryName, source }] }; const request = this.processRequest(CommandNames.CompletionDetails, args); const response = this.processResponse(request); From 18bddab1f63a2eb9c764649ff2ce28e0bf6ae07f Mon Sep 17 00:00:00 2001 From: Andy Hanson Date: Wed, 1 Nov 2017 14:24:04 -0700 Subject: [PATCH 2/3] Fix -- add "options" parameter too --- src/server/client.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/server/client.ts b/src/server/client.ts index 727bfbf29dd33..615e3101d76b5 100644 --- a/src/server/client.ts +++ b/src/server/client.ts @@ -192,7 +192,7 @@ namespace ts.server { }; } - getCompletionEntryDetails(fileName: string, position: number, entryName: string, source: string | undefined): CompletionEntryDetails { + getCompletionEntryDetails(fileName: string, position: number, entryName: string, options: FormatCodeOptions | FormatCodeSettings | undefined, source: string | undefined): CompletionEntryDetails { const args: protocol.CompletionDetailsRequestArgs = { ...this.createFileLocationRequestArgs(fileName, position), entryNames: [{ name: entryName, source }] }; const request = this.processRequest(CommandNames.CompletionDetails, args); From dd1700e95efbf819c834ed51451d2f62deb087f0 Mon Sep 17 00:00:00 2001 From: Andy Hanson Date: Thu, 2 Nov 2017 12:46:01 -0700 Subject: [PATCH 3/3] Mark "options" as unused --- src/server/client.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/server/client.ts b/src/server/client.ts index 615e3101d76b5..b3492cb8ae30d 100644 --- a/src/server/client.ts +++ b/src/server/client.ts @@ -192,7 +192,7 @@ namespace ts.server { }; } - getCompletionEntryDetails(fileName: string, position: number, entryName: string, options: FormatCodeOptions | FormatCodeSettings | undefined, source: string | undefined): CompletionEntryDetails { + getCompletionEntryDetails(fileName: string, position: number, entryName: string, _options: FormatCodeOptions | FormatCodeSettings | undefined, source: string | undefined): CompletionEntryDetails { const args: protocol.CompletionDetailsRequestArgs = { ...this.createFileLocationRequestArgs(fileName, position), entryNames: [{ name: entryName, source }] }; const request = this.processRequest(CommandNames.CompletionDetails, args);