fix(37287): check appropriate context with enabled useDefineForClassFields (#37323)

Author: a-tarasyuk

src/compiler/checker.ts

@@ -1412,7 +1412,7 @@ namespace ts {
                 return true;
             }
             if (isUsedInFunctionOrInstanceProperty(usage, declaration, container)) {
-                if (compilerOptions.target === ScriptTarget.ESNext && !!compilerOptions.useDefineForClassFields) {
+                if (compilerOptions.target === ScriptTarget.ESNext && !!compilerOptions.useDefineForClassFields && getContainingClass(declaration)) {
                     return (isPropertyDeclaration(declaration) || isParameterPropertyDeclaration(declaration, declaration.parent)) &&
                         !isPropertyImmediatelyReferencedWithinDeclaration(declaration, usage, /*stopAtAnyPropertyDeclaration*/ true);
                 }

tests/baselines/reference/defineVariables_useDefineForClassFields.js

@@ -0,0 +1,9 @@
+//// [defineVariables_useDefineForClassFields.ts]
+const a = () => b()
+const b = () => null
+a()
+
+//// [defineVariables_useDefineForClassFields.js]
+const a = () => b();
+const b = () => null;
+a();

tests/baselines/reference/defineVariables_useDefineForClassFields.symbols

@@ -0,0 +1,11 @@
+=== tests/cases/compiler/defineVariables_useDefineForClassFields.ts ===
+const a = () => b()
+>a : Symbol(a, Decl(defineVariables_useDefineForClassFields.ts, 0, 5))
+>b : Symbol(b, Decl(defineVariables_useDefineForClassFields.ts, 1, 5))
+
+const b = () => null
+>b : Symbol(b, Decl(defineVariables_useDefineForClassFields.ts, 1, 5))
+
+a()
+>a : Symbol(a, Decl(defineVariables_useDefineForClassFields.ts, 0, 5))
+

tests/baselines/reference/defineVariables_useDefineForClassFields.types

@@ -0,0 +1,16 @@
+=== tests/cases/compiler/defineVariables_useDefineForClassFields.ts ===
+const a = () => b()
+>a : () => any
+>() => b() : () => any
+>b() : any
+>b : () => any
+
+const b = () => null
+>b : () => any
+>() => null : () => any
+>null : null
+
+a()
+>a() : any
+>a : () => any
+

tests/cases/compiler/defineVariables_useDefineForClassFields.ts

@@ -0,0 +1,6 @@
+// @target: ESNext
+// @useDefineForClassFields: true
+
+const a = () => b()
+const b = () => null
+a()