Merge pull request #976 from Microsoft/privatePropertiesBeingTooPrivate

Fixed findAllRefs/getOccs bug where private properties declared in the constructor were only local to the constructor.

Author: DanielRosenwasser

src/compiler/types.ts

@@ -766,7 +766,7 @@ module ts {
     }
 
     export enum SymbolFlags {
-        FunctionScopedVariable = 0x00000001, // Variable (var) or parameter
+        FunctionScopedVariable = 0x00000001,  // Variable (var) or parameter
         Property               = 0x00000002,  // Property or enum member
         EnumMember             = 0x00000004,  // Enum member
         Function               = 0x00000008,  // Function

src/services/services.ts

@@ -3836,7 +3836,7 @@ module ts {
                 if (symbol.getFlags() && (SymbolFlags.Property | SymbolFlags.Method)) {
                     var privateDeclaration = forEach(symbol.getDeclarations(), d => (d.flags & NodeFlags.Private) ? d : undefined);
                     if (privateDeclaration) {
-                        return privateDeclaration.parent;
+                        return getAncestor(privateDeclaration, SyntaxKind.ClassDeclaration);
                     }
                 }
 

tests/cases/fourslash/findAllRefsOnPrivateParameterProperty1.ts

@@ -0,0 +1,18 @@
+/// <reference path="fourslash.ts" />
+
+////class ABCD {
+////    constructor(private x: number, public y: number, private [|z|]: number) {
+////    }
+////
+////    func() {
+////        return this.[|z|];
+////    }
+////}
+
+test.ranges().forEach(r => {
+    goTo.position(r.start);
+
+    test.ranges().forEach(range => {
+        verify.referencesAtPositionContains(range);
+    });
+});