fix(56052): Rename Symbol F2 with "pure keyof" is not possible - but it is possible if "wrapped as calculated property" (#56061)

Co-authored-by: Nathan Shively-Sanders <[email protected]>

Author: a-tarasyuk

src/services/findAllReferences.ts

@@ -163,6 +163,7 @@ import {
     isParameterPropertyDeclaration,
     isPrivateIdentifierClassElementDeclaration,
     isPropertyAccessExpression,
+    isPropertySignature,
     isQualifiedName,
     isReferencedFile,
     isReferenceFileLocation,
@@ -2471,7 +2472,7 @@ export namespace Core {
                 if (isStringLiteralLike(ref) && ref.text === node.text) {
                     if (type) {
                         const refType = getContextualTypeFromParentOrAncestorTypeNode(ref, checker);
-                        if (type !== checker.getStringType() && type === refType) {
+                        if (type !== checker.getStringType() && (type === refType || isStringLiteralPropertyReference(ref, checker))) {
                             return nodeEntry(ref, EntryKind.StringLiteral);
                         }
                     }
@@ -2489,6 +2490,12 @@ export namespace Core {
         }];
     }
 
+    function isStringLiteralPropertyReference(node: StringLiteralLike, checker: TypeChecker) {
+        if (isPropertySignature(node.parent)) {
+            return checker.getPropertyOfType(checker.getTypeAtLocation(node.parent.parent), node.text);
+        }
+    }
+
     // For certain symbol kinds, we need to include other symbols in the search set.
     // This is not needed when searching for re-exports.
     function populateSearchSymbolSet(symbol: Symbol, location: Node, checker: TypeChecker, isForRename: boolean, providePrefixAndSuffixText: boolean, implementations: boolean): Symbol[] {

tests/baselines/reference/renameStringLiteralTypes4.baseline.jsonc

@@ -0,0 +1,9 @@
+// === findRenameLocations ===
+// === /tests/cases/fourslash/renameStringLiteralTypes4.ts ===
+// interface I {
+//     <|"[|Prop 1RENAME|]": string;|>
+// }
+// 
+// declare const fn: <K extends keyof I>(p: K) => void
+// 
+// fn("[|Prop 1RENAME|]"/*RENAME*/)

tests/baselines/reference/renameStringLiteralTypes5.baseline.jsonc

@@ -0,0 +1,9 @@
+// === findRenameLocations ===
+// === /tests/cases/fourslash/renameStringLiteralTypes5.ts ===
+// type T = {
+//     <|"[|Prop 1RENAME|]": string;|>
+// }
+// 
+// declare const fn: <K extends keyof T>(p: K) => void
+// 
+// fn("[|Prop 1RENAME|]"/*RENAME*/)

tests/cases/fourslash/renameStringLiteralTypes4.ts

@@ -0,0 +1,11 @@
+/// <reference path="fourslash.ts" />
+
+////interface I {
+////    "Prop 1": string;
+////}
+////
+////declare const fn: <K extends keyof I>(p: K) => void
+////
+////fn("Prop 1"/**/)
+
+verify.baselineRename("", {});

tests/cases/fourslash/renameStringLiteralTypes5.ts

@@ -0,0 +1,11 @@
+/// <reference path="fourslash.ts" />
+
+////type T = {
+////    "Prop 1": string;
+////}
+////
+////declare const fn: <K extends keyof T>(p: K) => void
+////
+////fn("Prop 1"/**/)
+
+verify.baselineRename("", {});