From ba02157b8aca623484d921ab03b660d799a3ecbb Mon Sep 17 00:00:00 2001 From: zhengbli Date: Wed, 10 Aug 2016 00:08:08 -0700 Subject: [PATCH] fix 9850 --- TS.fsx | 5 ++++- baselines/dom.generated.d.ts | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/TS.fsx b/TS.fsx index 73adf2831..8e5f4cef0 100644 --- a/TS.fsx +++ b/TS.fsx @@ -262,7 +262,10 @@ let EmitProperties flavor prefix (emitScope: EmitScope) (i: Browser.Interface)= | Some comment -> Pt.printl "%s" comment | _ -> () - if Option.isNone (findRemovedItem p.Name ItemKind.Property i.Name) then + // Treat window.name specially because of https://github.com/Microsoft/TypeScript/issues/9850 + if p.Name = "name" && i.Name = "Window" && emitScope = EmitScope.All then + Pt.printl "declare const name: never;" + elif Option.isNone (findRemovedItem p.Name ItemKind.Property i.Name) then match findOverriddenItem p.Name ItemKind.Property i.Name with | Some p' -> emitPropertyFromJson p' | None -> diff --git a/baselines/dom.generated.d.ts b/baselines/dom.generated.d.ts index 255f1c88c..5088c95e7 100644 --- a/baselines/dom.generated.d.ts +++ b/baselines/dom.generated.d.ts @@ -14305,7 +14305,7 @@ declare var location: Location; declare var locationbar: BarProp; declare var menubar: BarProp; declare var msCredentials: MSCredentials; -declare var name: string; +declare const name: never; declare var navigator: Navigator; declare var offscreenBuffering: string | boolean; declare var onabort: (this: Window, ev: UIEvent) => any;