File tree Expand file tree Collapse file tree 1 file changed +7
-1
lines changed Expand file tree Collapse file tree 1 file changed +7
-1
lines changed Original file line number Diff line number Diff line change @@ -152,6 +152,8 @@ module InputIdlJson =
152152 let hasType itemName =
153153 allTypedefsMap.ContainsKey itemName
154154
155+ // Converts new JSON types to existing matching XML types
156+ // to reduce code duplication before removing XML support
155157 module Compat =
156158 let xNamespace = XNamespace.Get " http://schemas.microsoft.com/ie/webidl-xml"
157159
@@ -1508,15 +1510,19 @@ module Emit =
15081510 let emitTypeDefFromJson ( typeDef : InputJsonType.Root ) =
15091511 Pt.Printl " type %s = %s ;" typeDef.Name.Value typeDef.Type.Value
15101512
1513+ // Load typedefs from XML input
15111514 let mutable map = browser.Typedefs |> Array.map( fun i -> ( i.NewType, i)) |> Map.ofArray
1515+ // Load and merge typedefs from new JSON input
15121516 InputIdlJson.inputIdl.Typedefs
15131517 |> Array.iter ( InputIdlJson.Compat.convertTypedef >> ( fun i -> map <- map.Add( i.NewType, i)))
1514-
1518+
1519+ // Filter by removedType.json + knownWorkerInterfaces.json
15151520 map |> Map.toArray |> Array.map snd
15161521 |> Array.filter ( fun typedef -> getRemovedItemByName typedef.NewType ItemKind.TypeDef " " |> Option.isNone)
15171522 |> Array.filter ( fun i -> ( flavor <> Flavor.Worker || knownWorkerInterfaces.Contains i.NewType))
15181523 |> Array.iter emitTypeDef
15191524
1525+ // Load manual additions from addedType.json
15201526 InputJson.getAddedItems ItemKind.TypeDef flavor
15211527 |> Array.iter emitTypeDefFromJson
15221528
You can’t perform that action at this time.
0 commit comments