Skip to content

Commit 9ea8ced

Browse files
committed
Merge branch 'master' of https://github.com/Microsoft/TSJS-lib-generator into constructors
2 parents 7a30b26 + 475f27e commit 9ea8ced

File tree

5 files changed

+32
-21
lines changed

5 files changed

+32
-21
lines changed

TS.fsx

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -710,7 +710,7 @@ module Emit =
710710
let extendedTypes =
711711
["ArrayBuffer";"ArrayBufferView";"Int8Array";"Uint8Array";"Int16Array";"Uint16Array";"Int32Array";"Uint32Array";"Uint8ClampedArray";"Float32Array";"Float64Array";"DataView"]
712712

713-
let integerTypes =
713+
let integerTypes =
714714
["byte";"octet";"short";"unsigned short";"long";"unsigned long";"long long";"unsigned long long"]
715715

716716
/// Get typescript type using object dom type, object name, and it's associated interface name
@@ -740,7 +740,7 @@ module Emit =
740740
// Name of an interface / enum / dict. Just return itself
741741
if allInterfacesMap.ContainsKey objDomType ||
742742
allCallbackFuncs.ContainsKey objDomType ||
743-
allDictionariesMap.ContainsKey objDomType ||
743+
allDictionariesMap.ContainsKey objDomType ||
744744
allEnumsMap.ContainsKey objDomType then
745745
objDomType
746746
// Name of a type alias. Just return itself
@@ -1124,7 +1124,7 @@ module Emit =
11241124
"%saddEventListener(type: string, listener: EventListenerOrEventListenerObject, useCapture?: boolean): void;"
11251125
fPrefix
11261126

1127-
let EmitConstructorSignature (i:Browser.Interface) =
1127+
let EmitConstructorSignature flavor (i:Browser.Interface) =
11281128
let emitConstructorSigFromJson (c: InputJsonType.Root) =
11291129
c.Signatures |> Array.iter (Pt.Printl "%s;")
11301130

@@ -1133,9 +1133,9 @@ module Emit =
11331133
let paramsString = ParamsToString pCombList
11341134
Pt.Printl "new(%s): %s;" paramsString i.Name
11351135

1136-
let removedCtor = getRemovedItems ItemKind.Constructor Flavor.All |> Array.tryFind (matchInterface i.Name)
1136+
let removedCtor = getRemovedItems ItemKind.Constructor flavor |> Array.tryFind (matchInterface i.Name)
11371137
if Option.isNone removedCtor then
1138-
let overriddenCtor = getOverriddenItems ItemKind.Constructor Flavor.All |> Array.tryFind (matchInterface i.Name)
1138+
let overriddenCtor = getOverriddenItems ItemKind.Constructor flavor |> Array.tryFind (matchInterface i.Name)
11391139
match overriddenCtor with
11401140
| Some c' -> emitConstructorSigFromJson c'
11411141
| _ ->
@@ -1145,15 +1145,15 @@ module Emit =
11451145
else
11461146
Pt.Printl "new(): %s;" i.Name
11471147

1148-
getAddedItemsByInterfaceName ItemKind.Constructor Flavor.All i.Name
1148+
getAddedItemsByInterfaceName ItemKind.Constructor flavor i.Name
11491149
|> Array.iter emitConstructorSigFromJson
11501150

11511151
let EmitConstructor flavor (i:Browser.Interface) =
11521152
Pt.Printl "declare var %s: {" i.Name
11531153
Pt.IncreaseIndent()
11541154

11551155
Pt.Printl "prototype: %s;" i.Name
1156-
EmitConstructorSignature i
1156+
EmitConstructorSignature flavor i
11571157
EmitConstants i
11581158
let prefix = ""
11591159
EmitMembers flavor prefix EmitScope.StaticOnly (InterfaceOrNamespace.Interface i)
@@ -1569,11 +1569,11 @@ module Emit =
15691569
List.contains p.Type integerTypes
15701570

15711571
// check anonymous unsigned long getter and length property
1572-
let isIterableGetter (m: Browser.Method) =
1572+
let isIterableGetter (m: Browser.Method) =
15731573
m.Getter = Some 1 && m.Params.Length = 1 && isIntegerKeyParam m.Params.[0]
15741574

15751575
let findIterableGetter() =
1576-
let anonymousGetter =
1576+
let anonymousGetter =
15771577
if (i.AnonymousMethods.IsSome) then Array.tryFind isIterableGetter i.AnonymousMethods.Value.Methods
15781578
else None
15791579

@@ -1603,7 +1603,7 @@ module Emit =
16031603
Pt.Printl ""
16041604

16051605
browser.Interfaces |> Array.iter EmitIterator
1606-
1606+
16071607
fprintf target "%s" (Pt.GetResult())
16081608
target.Flush()
16091609
target.Close()

baselines/dom.generated.d.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3821,8 +3821,8 @@ declare var ForeignFetchEvent: {
38213821
};
38223822

38233823
interface FormData {
3824-
append(name: string, value: string | Blob, fileName?: string): void;
3825-
append(name: string, value: string | Blob, fileName?: string): void;
3824+
append(name: string, value: string): void;
3825+
append(name: string, blobValue: Blob, filename?: string): void;
38263826
delete(name: string): void;
38273827
get(name: string): FormDataEntryValue | null;
38283828
getAll(name: string): FormDataEntryValue[];
@@ -3833,7 +3833,7 @@ interface FormData {
38333833

38343834
declare var FormData: {
38353835
prototype: FormData;
3836-
new (form?: HTMLFormElement): FormData;
3836+
new(): FormData;
38373837
};
38383838

38393839
interface GainNode extends AudioNode {

baselines/webworker.generated.d.ts

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -389,6 +389,22 @@ declare var FileReader: {
389389
readonly LOADING: number;
390390
};
391391

392+
interface FormData {
393+
append(name: string, value: string): void;
394+
append(name: string, blobValue: Blob, filename?: string): void;
395+
delete(name: string): void;
396+
get(name: string): FormDataEntryValue | null;
397+
getAll(name: string): FormDataEntryValue[];
398+
has(name: string): boolean;
399+
set(name: string, value: string): void;
400+
set(name: string, blobValue: Blob, filename?: string): void;
401+
}
402+
403+
declare var FormData: {
404+
prototype: FormData;
405+
new(): FormData;
406+
};
407+
392408
interface Headers {
393409
append(name: string, value: string): void;
394410
delete(name: string): void;

inputfiles/knownWorkerInterfaces.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@
3333
"FileList",
3434
"FileReader",
3535
"ForEachCallback",
36+
"FormData",
3637
"FunctionStringCallback",
3738
"GetNotificationOptions",
3839
"GlobalFetch",

inputfiles/overridingTypes.json

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -359,7 +359,8 @@
359359
{
360360
"kind": "constructor",
361361
"interface": "FormData",
362-
"signatures": ["new (form?: HTMLFormElement): FormData"]
362+
"flavor": "Worker",
363+
"signatures": ["new(): FormData"]
363364
},
364365
{
365366
"kind": "constructor",
@@ -950,13 +951,6 @@
950951
"name": "createDocument",
951952
"signatures": ["createDocument(namespaceURI: string | null, qualifiedName: string | null, doctype: DocumentType | null): Document"]
952953
},
953-
{
954-
"kind": "method",
955-
"interface": "FormData",
956-
"name": "append",
957-
"flavor": "Web",
958-
"signatures": ["append(name: string, value: string | Blob, fileName?: string): void"]
959-
},
960954
{
961955
"kind": "method",
962956
"interface": "EventTarget",

0 commit comments

Comments
 (0)