removeTypes cleanup

Author: saschanaz

inputfiles/removedTypes.json

@@ -87,13 +87,6 @@
                     }
                 }
             },
-            "Document": {
-                "methods": {
-                    "method": {
-                        "evaluate": null
-                    }
-                }
-            },
             "FederatedCredential": null,
             "HTMLAreasCollection": null,
             "HTMLBodyElement": {
@@ -108,27 +101,6 @@
                     }
                 }
             },
-            "HTMLElement": {
-                "methods": {
-                    "method": {
-                        "scrollIntoView": null,
-                        "insertAdjacentElement": null,
-                        "insertAdjacentHTML": null,
-                        "insertAdjacentText": null
-                    }
-                }
-            },
-            "HTMLHRElement": {
-                "implements": null
-            },
-            "HTMLIFrameElement": {
-                "properties": {
-                    "property": {
-                        "onload": null
-                    }
-                }
-            },
-            "MediaQueryListListener": null,
             "MessageEvent": {
                 "methods": {
                     "method": {
@@ -139,18 +111,8 @@
             "MSCredentials": null,
             "MSDCCEvent": null,
             "MSDSHEvent": null,
-            "MSPortRange": null,
             "MSStreamReader": null,
-            "OverconstrainedErrorEvent": null,
             "PasswordCredential": null,
-            "Screen": {
-                "methods": {
-                    "method": {
-                        "msLockOrientation": null,
-                        "msUnlockOrientation": null
-                    }
-                }
-            },
             "StorageEvent": {
                 "methods": {
                     "method": {
@@ -197,11 +159,6 @@
                     }
                 }
             },
-            "SVGFilterElement": {
-                "implements": [
-                    "SVGUnitTypes"
-                ]
-            },
             "SVGGradientElement": {
                 "implements": [
                     "SVGUnitTypes"
@@ -221,9 +178,6 @@
             "SVGPoint": null,
             "SVGRect": null,
             "SVGSVGElement": {
-                "implements": [
-                    "SVGUnitTypes"
-                ],
                 "properties": {
                     "property": {
                         "onabort": null,
@@ -233,11 +187,6 @@
                     }
                 }
             },
-            "SVGViewElement": {
-                "implements": [
-                    "SVGUnitTypes"
-                ]
-            },
             "WebKitCSSMatrix": null,
             "WebKitDirectoryEntry": null,
             "WebKitDirectoryReader": null,
@@ -265,27 +214,11 @@
                     "GlobalFetch"
                 ]
             },
-            "WheelEvent": {
-                "properties": {
-                    "property": {
-                        "wheelDelta": null,
-                        "wheelDeltaX": null,
-                        "wheelDeltaY": null
-                    }
-                }
-            },
             "WorkerGlobalScope": {
                 "implements": [
                     "GlobalFetch"
                 ]
             },
-            "XPathEvaluator": {
-                "methods": {
-                    "method": {
-                        "evaluate": null
-                    }
-                }
-            },
             "XPathNSResolver": null
         }
     },
@@ -314,20 +247,6 @@
                         "portRange": null
                     }
                 }
-            },
-            "RTCRtpContributingSource": {
-                "members": {
-                    "member": {
-                        "csrc": null
-                    }
-                }
-            },
-            "MediaTrackConstraintSet": {
-                "members": {
-                    "member": {
-                        "echoCancelation": null
-                    }
-                }
             }
         }
     },

src/index.ts

@@ -197,12 +197,11 @@ function emitDom() {
 
         function filterByNull(obj: any, template: any) {
             if (!template) return obj;
-            const filtered: any = {};
-            for (const k in obj) {
-                if (!template.hasOwnProperty(k)) {
-                    filtered[k] = obj[k];
-                }
-                else if (Array.isArray(template[k])) {
+            const filtered = { ...obj };
+            for (const k in template) {
+                if (!obj[k]) {
+                    console.warn(`removedTypes.json has a redundant field ${k} in ${JSON.stringify(template)}`);
+                } else if (Array.isArray(template[k])) {
                     if (!Array.isArray(obj[k])) {
                         throw new Error(`Removal template ${k} is an array but the original field is not`);
                     }
@@ -211,9 +210,14 @@ function emitDom() {
                         const name = typeof item === "string" ? item : (item.name || item["new-type"]);
                         return !template[k].includes(name);
                     });
+                    if (filtered[k].length === obj[k].length) {
+                        console.warn(`removedTypes.json has a redundant array item in ${JSON.stringify(template[k])}`);
+                    }
                 }
                 else if (template[k] !== null) {
                     filtered[k] = filterByNull(obj[k], template[k]);
+                } else {
+                    delete filtered[k];
                 }
             }
             return filtered;