Usage of .Result is problematic

[soutchilin]

PowerPlatform-DataverseServiceClient/src/GeneralTools/DataverseClient/Client/ServiceClient.cs

Line 1580 in 44a1af6

var result = _connectionSvc.Command_WebExecuteAsync(queryString, body, method, customHeaders, contentType, string.Empty, CallerId, _disableConnectionLocking, MaxRetryCount, RetryPauseTime, cancellationToken: cancellationToken).Result;

Hi,

according to https://learn.microsoft.com/en-us/aspnet/core/fundamentals/best-practices?view=aspnetcore-3.0#avoid-blocking-calls the usage of .Result is not okay and can lead to deadlocks. Please consider to use GetAwaiter().GetResult().

Kind regards,
Alexander

[MattB-msft]

Thanks for pointing this out,

We have gone back and forth on this and discussed this at somewhat great lengths with the folks in the .net team. The general guidance we are getting back is 'it depends on framework / core / version of core' as to the potential for the deadlocking behavior to occur.

Public Doc's are generally targeted at the leading-edge vs the spectrum.

In light of the pending drop of support for .net core 3.1, we can discuss it again.

[MattB-msft]

in the next drop we are dropping support for .net core 3.x and 5.x, as such we will take this suggestion up and make this change.