Use input file OpenApi format / version as the default output format / version in Hidi #658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielmbaluka
requested review from
MaggieKimani1,
darrelmiller and
irvinesunday
Contributor
MaggieKimani1
left a comment
MaggieKimani1
left a comment
There was a problem hiding this comment.
Should we do the same for OpenApi version too?
Contributor
Author
I think we would want to. cc @darrelmiller |
| string input, | ||
| FileInfo output, | ||
| OpenApiSpecVersion version, | ||
| OpenApiFormat format, |
Member
There was a problem hiding this comment.
Try to use OpenApiFormat? (nullable OpenApiFormat) so that you can distinguish between being sent a parameter or not.
Contributor
Author
There was a problem hiding this comment.
@darrelmiller that's a good suggestion. I adopted it. Thank you.
danielmbaluka
force-pushed
the
feature/dm/use-input-file-format-as-default-ouput-format-in-hidi
branch
3 times, most recently
from
93a31f7 to
03ab201
Compare
danielmbaluka
changed the title
danielmbaluka
force-pushed
the
feature/dm/use-input-file-format-as-default-ouput-format-in-hidi
branch
from
03ab201 to
f1c3c31
Compare
Contributor
Author
@MaggieKimani1 @darrelmiller this has been implemented. Thank you. |
MaggieKimani1
approved these changes
Jan 10, 2022
danielmbaluka
force-pushed
the
feature/dm/use-input-file-format-as-default-ouput-format-in-hidi
branch
from
f1c3c31 to
4e0639f
Compare
danielmbaluka
force-pushed
the
feature/dm/use-input-file-format-as-default-ouput-format-in-hidi
branch
from
bf00ec7 to
a06ab0c
Compare
darrelmiller
deleted the
feature/dm/use-input-file-format-as-default-ouput-format-in-hidi
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #651
The current
transformcommand in Hidi defaults toJSONas the output format when no explicit format is specified. This is not the intended behaviour in most cases.This PR improves the
transformcommand by using the default input file format and OpenApi version as the output format and version when no format or version is explicitly specified.