Skip to content

Fix WriteValue for DateTimeOffset to write as string (i.e. with quotes) #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 28, 2018
Merged

Fix WriteValue for DateTimeOffset to write as string (i.e. with quotes) #322

merged 1 commit into from
Sep 28, 2018

Conversation

@PerthCharern
Copy link
Contributor

@PerthCharern PerthCharern commented Sep 27, 2018

  • Add WriteValue for DateTime type
  • Fix WriteValue for DateTimeOffset type to convert to write as string with specific format. This will force it to be written just like string (ie. with double-quotes in JSON and single-quotes in YAML.)
  • Add Tests

Fix #291

@PerthCharern
- Add WriteValue for DateTime type
6e20485 
- Fix WriteValue for DateTimeOffset type to convert to write as string with specific format. This will force it to be written just like string (ie. with double-quotes in JSON and single-quotes in YAML.)
- Add Tests
Shwetap05
Shwetap05 approved these changes Sep 28, 2018
View reviewed changes
Copy link
Member

@Shwetap05 Shwetap05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@PerthCharern PerthCharern merged commit aaf4161 into master Sep 28, 2018
@PerthCharern PerthCharern mentioned this pull request Sep 28, 2018
Merged
PerthCharern added a commit that referenced this pull request Oct 1, 2018
@PerthCharern
Merge pull request #325 from Microsoft/perthcharern/fixDateTimeJson
212b6ac 
vNext merge of #322
@ArthNRick ArthNRick mentioned this pull request Oct 5, 2018
Closed
@PerthCharern PerthCharern mentioned this pull request Oct 16, 2018
Closed
@PerthCharern PerthCharern deleted the perthcharern/fixDateTimeJson branch April 28, 2019 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darrelmiller darrelmiller Awaiting requested review from darrelmiller

@scott-lin scott-lin Awaiting requested review from scott-lin

1 more reviewer

@Shwetap05 Shwetap05 Shwetap05 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@PerthCharern @Shwetap05