Allow composite expression #320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allow composite expression with the following formats:
- Strings with runtime expression embedded in { }
- Plain strings without any runtime expression
- Strings with {$xxxx} where xxxx doesn't constitute a valid runtime expression is NOT allowed. A set of braces with a dolalr sign denotes a runtime expression in a composite expression and should not be used in other random scenarios.
- Adjust unit tests
Contributor
Author
|
@Shwetap05 @darrelmiller Do we have a consensus based on #313 on which branch to use? Are we still using vNext? Based on my understanding, we are doing this:
The change in this PR should then be merged into both master and vNext. |
Member
|
@PerthCharern we discussed to stick with vNext for preview features and yes bug fixes should go to both master and vNext |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #287
Allow composite expression with the following formats:
Strings with {$xxxx} where xxxx doesn't constitute a valid runtime expression is NOT allowed. A set of braces with a dollar sign denotes a runtime expression in a composite expression and should not be used in other random scenarios.
Runtime expressions should not be static. Theoretically, we don't want any classes in our object to be static. If the UrlExpression class is modified in one object in any arbitrary way, it should not effect a UrlExpression class in a different object.
Adjust unit tests