From b1822fee52108d68e2d0e28df347ac88e3d06b1a Mon Sep 17 00:00:00 2001 From: Maggie Kimani Date: Tue, 19 Dec 2023 17:37:12 +0300 Subject: [PATCH] Revert "Fix unresolved references in OpenApiWalker" --- src/Microsoft.OpenApi/Services/OpenApiWalker.cs | 3 +-- .../Walkers/WalkerLocationTests.cs | 13 ------------- 2 files changed, 1 insertion(+), 15 deletions(-) diff --git a/src/Microsoft.OpenApi/Services/OpenApiWalker.cs b/src/Microsoft.OpenApi/Services/OpenApiWalker.cs index 446663f6b..7ce011f4b 100644 --- a/src/Microsoft.OpenApi/Services/OpenApiWalker.cs +++ b/src/Microsoft.OpenApi/Services/OpenApiWalker.cs @@ -1091,8 +1091,7 @@ private void Walk(string context, Action walk) /// private bool ProcessAsReference(IOpenApiReferenceable referenceable, bool isComponent = false) { - var isReference = referenceable.Reference != null && - (!isComponent || referenceable.UnresolvedReference); + var isReference = referenceable.Reference != null && !isComponent; if (isReference) { Walk(referenceable); diff --git a/test/Microsoft.OpenApi.Tests/Walkers/WalkerLocationTests.cs b/test/Microsoft.OpenApi.Tests/Walkers/WalkerLocationTests.cs index 83b7eb341..09c808a1e 100644 --- a/test/Microsoft.OpenApi.Tests/Walkers/WalkerLocationTests.cs +++ b/test/Microsoft.OpenApi.Tests/Walkers/WalkerLocationTests.cs @@ -233,18 +233,6 @@ public void LocateReferences() Headers = new Dictionary { ["test-header"] = testHeader - }, - SecuritySchemes = new Dictionary - { - ["test-secScheme"] = new OpenApiSecurityScheme - { - Reference = new OpenApiReference - { - Id = "reference-to-scheme", - Type = ReferenceType.SecurityScheme - }, - UnresolvedReference = true - } } } }; @@ -257,7 +245,6 @@ public void LocateReferences() "referenceAt: #/paths/~1/get/responses/200/content/application~1json/schema", "referenceAt: #/paths/~1/get/responses/200/headers/test-header", "referenceAt: #/components/schemas/derived/anyOf/0", - "referenceAt: #/components/securitySchemes/test-secScheme", "referenceAt: #/components/headers/test-header/schema" }); }