diff --git a/src/Microsoft.OpenApi.Readers/Services/OpenApiRemoteReferenceCollector.cs b/src/Microsoft.OpenApi.Readers/Services/OpenApiRemoteReferenceCollector.cs index 9a5ba9213..475d3073f 100644 --- a/src/Microsoft.OpenApi.Readers/Services/OpenApiRemoteReferenceCollector.cs +++ b/src/Microsoft.OpenApi.Readers/Services/OpenApiRemoteReferenceCollector.cs @@ -13,12 +13,7 @@ namespace Microsoft.OpenApi.Readers.Services /// internal class OpenApiRemoteReferenceCollector : OpenApiVisitorBase { - private OpenApiDocument _document; private Dictionary _references = new Dictionary(); - public OpenApiRemoteReferenceCollector(OpenApiDocument document) - { - _document = document; - } /// /// List of external references collected from OpenApiDocument diff --git a/src/Microsoft.OpenApi.Readers/Services/OpenApiWorkspaceLoader.cs b/src/Microsoft.OpenApi.Readers/Services/OpenApiWorkspaceLoader.cs index be899117b..44b961ffe 100644 --- a/src/Microsoft.OpenApi.Readers/Services/OpenApiWorkspaceLoader.cs +++ b/src/Microsoft.OpenApi.Readers/Services/OpenApiWorkspaceLoader.cs @@ -26,7 +26,7 @@ internal async Task LoadAsync(OpenApiReference reference, Ope document.Workspace = _workspace; // Collect remote references by walking document - var referenceCollector = new OpenApiRemoteReferenceCollector(document); + var referenceCollector = new OpenApiRemoteReferenceCollector(); var collectorWalker = new OpenApiWalker(referenceCollector); collectorWalker.Walk(document); diff --git a/test/Microsoft.OpenApi.Readers.Tests/V3Tests/OpenApiDocumentTests.cs b/test/Microsoft.OpenApi.Readers.Tests/V3Tests/OpenApiDocumentTests.cs index f3be46ab6..62eef0d9a 100644 --- a/test/Microsoft.OpenApi.Readers.Tests/V3Tests/OpenApiDocumentTests.cs +++ b/test/Microsoft.OpenApi.Readers.Tests/V3Tests/OpenApiDocumentTests.cs @@ -24,8 +24,6 @@ public class OpenApiDocumentTests { private const string SampleFolderPath = "V3Tests/Samples/OpenApiDocument/"; - private readonly ITestOutputHelper _output; - public T Clone(T element) where T : IOpenApiSerializable { using (var stream = new MemoryStream()) diff --git a/test/Microsoft.OpenApi.Tests/Models/OpenApiCallbackTests.cs b/test/Microsoft.OpenApi.Tests/Models/OpenApiCallbackTests.cs index 93b78e71b..d6c596b5a 100644 --- a/test/Microsoft.OpenApi.Tests/Models/OpenApiCallbackTests.cs +++ b/test/Microsoft.OpenApi.Tests/Models/OpenApiCallbackTests.cs @@ -9,7 +9,6 @@ using Microsoft.OpenApi.Writers; using VerifyXunit; using Xunit; -using Xunit.Abstractions; namespace Microsoft.OpenApi.Tests.Models { @@ -98,13 +97,6 @@ public class OpenApiCallbackTests } }; - private readonly ITestOutputHelper _output; - - public OpenApiCallbackTests(ITestOutputHelper output) - { - _output = output; - } - [Theory] [InlineData(true)] [InlineData(false)] diff --git a/test/Microsoft.OpenApi.Tests/Models/OpenApiComponentsTests.cs b/test/Microsoft.OpenApi.Tests/Models/OpenApiComponentsTests.cs index 879e89cef..c428a5b55 100644 --- a/test/Microsoft.OpenApi.Tests/Models/OpenApiComponentsTests.cs +++ b/test/Microsoft.OpenApi.Tests/Models/OpenApiComponentsTests.cs @@ -7,7 +7,6 @@ using Microsoft.OpenApi.Extensions; using Microsoft.OpenApi.Models; using Xunit; -using Xunit.Abstractions; namespace Microsoft.OpenApi.Tests.Models { @@ -245,13 +244,6 @@ public class OpenApiComponentsTests } }; - private readonly ITestOutputHelper _output; - - public OpenApiComponentsTests(ITestOutputHelper output) - { - _output = output; - } - [Fact] public void SerializeBasicComponentsAsJsonWorks() { diff --git a/test/Microsoft.OpenApi.Tests/Models/OpenApiDocumentTests.cs b/test/Microsoft.OpenApi.Tests/Models/OpenApiDocumentTests.cs index 9ae0e1ce9..e185183a4 100644 --- a/test/Microsoft.OpenApi.Tests/Models/OpenApiDocumentTests.cs +++ b/test/Microsoft.OpenApi.Tests/Models/OpenApiDocumentTests.cs @@ -1278,13 +1278,6 @@ public class OpenApiDocumentTests Components = AdvancedComponents }; - private readonly ITestOutputHelper _output; - - public OpenApiDocumentTests(ITestOutputHelper output) - { - _output = output; - } - [Theory] [InlineData(false)] [InlineData(true)] diff --git a/test/Microsoft.OpenApi.Tests/Models/OpenApiExampleTests.cs b/test/Microsoft.OpenApi.Tests/Models/OpenApiExampleTests.cs index e12a7d100..6b610b921 100644 --- a/test/Microsoft.OpenApi.Tests/Models/OpenApiExampleTests.cs +++ b/test/Microsoft.OpenApi.Tests/Models/OpenApiExampleTests.cs @@ -11,7 +11,6 @@ using Microsoft.OpenApi.Writers; using VerifyXunit; using Xunit; -using Xunit.Abstractions; namespace Microsoft.OpenApi.Tests.Models { @@ -101,13 +100,6 @@ public class OpenApiExampleTests } }; - private readonly ITestOutputHelper _output; - - public OpenApiExampleTests(ITestOutputHelper output) - { - _output = output; - } - [Theory] [InlineData(true)] [InlineData(false)] diff --git a/test/Microsoft.OpenApi.Tests/Models/OpenApiHeaderTests.cs b/test/Microsoft.OpenApi.Tests/Models/OpenApiHeaderTests.cs index d45bd0038..55de71a6d 100644 --- a/test/Microsoft.OpenApi.Tests/Models/OpenApiHeaderTests.cs +++ b/test/Microsoft.OpenApi.Tests/Models/OpenApiHeaderTests.cs @@ -41,13 +41,6 @@ public class OpenApiHeaderTests } }; - private readonly ITestOutputHelper _output; - - public OpenApiHeaderTests(ITestOutputHelper output) - { - _output = output; - } - [Theory] [InlineData(true)] [InlineData(false)] diff --git a/test/Microsoft.OpenApi.Tests/Models/OpenApiLinkTests.cs b/test/Microsoft.OpenApi.Tests/Models/OpenApiLinkTests.cs index 4a10be0ae..298bcbb51 100644 --- a/test/Microsoft.OpenApi.Tests/Models/OpenApiLinkTests.cs +++ b/test/Microsoft.OpenApi.Tests/Models/OpenApiLinkTests.cs @@ -10,7 +10,6 @@ using Microsoft.OpenApi.Writers; using VerifyXunit; using Xunit; -using Xunit.Abstractions; namespace Microsoft.OpenApi.Tests.Models { @@ -71,13 +70,6 @@ public class OpenApiLinkTests } }; - private readonly ITestOutputHelper _output; - - public OpenApiLinkTests(ITestOutputHelper output) - { - _output = output; - } - [Theory] [InlineData(true)] [InlineData(false)] diff --git a/test/Microsoft.OpenApi.Tests/Models/OpenApiOAuthFlowTests.cs b/test/Microsoft.OpenApi.Tests/Models/OpenApiOAuthFlowTests.cs index cd46ae02a..64dc27821 100644 --- a/test/Microsoft.OpenApi.Tests/Models/OpenApiOAuthFlowTests.cs +++ b/test/Microsoft.OpenApi.Tests/Models/OpenApiOAuthFlowTests.cs @@ -7,7 +7,6 @@ using Microsoft.OpenApi.Extensions; using Microsoft.OpenApi.Models; using Xunit; -using Xunit.Abstractions; namespace Microsoft.OpenApi.Tests.Models { @@ -38,13 +37,6 @@ public class OpenApiOAuthFlowTests } }; - private readonly ITestOutputHelper _output; - - public OpenApiOAuthFlowTests(ITestOutputHelper output) - { - _output = output; - } - [Fact] public void SerializeBasicOAuthFlowAsV3JsonWorks() { diff --git a/test/Microsoft.OpenApi.Tests/Models/OpenApiOAuthFlowsTests.cs b/test/Microsoft.OpenApi.Tests/Models/OpenApiOAuthFlowsTests.cs index 9860a926a..0a51fd4c7 100644 --- a/test/Microsoft.OpenApi.Tests/Models/OpenApiOAuthFlowsTests.cs +++ b/test/Microsoft.OpenApi.Tests/Models/OpenApiOAuthFlowsTests.cs @@ -7,7 +7,6 @@ using Microsoft.OpenApi.Extensions; using Microsoft.OpenApi.Models; using Xunit; -using Xunit.Abstractions; namespace Microsoft.OpenApi.Tests.Models { @@ -52,13 +51,6 @@ public class OpenApiOAuthFlowsTests } }; - private readonly ITestOutputHelper _output; - - public OpenApiOAuthFlowsTests(ITestOutputHelper output) - { - _output = output; - } - [Fact] public void SerializeBasicOAuthFlowsAsV3JsonWorks() { diff --git a/test/Microsoft.OpenApi.Tests/Models/OpenApiOperationTests.cs b/test/Microsoft.OpenApi.Tests/Models/OpenApiOperationTests.cs index f562e01a6..430f03cbb 100644 --- a/test/Microsoft.OpenApi.Tests/Models/OpenApiOperationTests.cs +++ b/test/Microsoft.OpenApi.Tests/Models/OpenApiOperationTests.cs @@ -7,7 +7,6 @@ using Microsoft.OpenApi.Extensions; using Microsoft.OpenApi.Models; using Xunit; -using Xunit.Abstractions; namespace Microsoft.OpenApi.Tests.Models { @@ -295,13 +294,6 @@ [new OpenApiSecurityScheme } }; - private readonly ITestOutputHelper _output; - - public OpenApiOperationTests(ITestOutputHelper output) - { - _output = output; - } - [Fact] public void SerializeBasicOperationAsV3JsonWorks() { diff --git a/test/Microsoft.OpenApi.Tests/Models/OpenApiParameterTests.cs b/test/Microsoft.OpenApi.Tests/Models/OpenApiParameterTests.cs index 8ffb122ef..70c16c7ac 100644 --- a/test/Microsoft.OpenApi.Tests/Models/OpenApiParameterTests.cs +++ b/test/Microsoft.OpenApi.Tests/Models/OpenApiParameterTests.cs @@ -12,7 +12,6 @@ using Microsoft.OpenApi.Writers; using VerifyXunit; using Xunit; -using Xunit.Abstractions; namespace Microsoft.OpenApi.Tests.Models { @@ -164,13 +163,6 @@ public class OpenApiParameterTests } }; - private readonly ITestOutputHelper _output; - - public OpenApiParameterTests(ITestOutputHelper output) - { - _output = output; - } - [Theory] [InlineData(ParameterStyle.Form, true)] [InlineData(ParameterStyle.SpaceDelimited, false)] diff --git a/test/Microsoft.OpenApi.Tests/Models/OpenApiRequestBodyTests.cs b/test/Microsoft.OpenApi.Tests/Models/OpenApiRequestBodyTests.cs index 78fcd0d07..901908e09 100644 --- a/test/Microsoft.OpenApi.Tests/Models/OpenApiRequestBodyTests.cs +++ b/test/Microsoft.OpenApi.Tests/Models/OpenApiRequestBodyTests.cs @@ -8,7 +8,6 @@ using Microsoft.OpenApi.Writers; using VerifyXunit; using Xunit; -using Xunit.Abstractions; namespace Microsoft.OpenApi.Tests.Models { @@ -53,13 +52,6 @@ public class OpenApiRequestBodyTests } }; - private readonly ITestOutputHelper _output; - - public OpenApiRequestBodyTests(ITestOutputHelper output) - { - _output = output; - } - [Theory] [InlineData(true)] [InlineData(false)] diff --git a/test/Microsoft.OpenApi.Tests/Models/OpenApiResponseTests.cs b/test/Microsoft.OpenApi.Tests/Models/OpenApiResponseTests.cs index 373305603..dd3767aa5 100644 --- a/test/Microsoft.OpenApi.Tests/Models/OpenApiResponseTests.cs +++ b/test/Microsoft.OpenApi.Tests/Models/OpenApiResponseTests.cs @@ -13,7 +13,6 @@ using Microsoft.OpenApi.Writers; using VerifyXunit; using Xunit; -using Xunit.Abstractions; namespace Microsoft.OpenApi.Tests.Models { @@ -109,13 +108,6 @@ public class OpenApiResponseTests } }; - private readonly ITestOutputHelper _output; - - public OpenApiResponseTests(ITestOutputHelper output) - { - _output = output; - } - [Theory] [InlineData(OpenApiSpecVersion.OpenApi3_0, OpenApiFormat.Json)] [InlineData(OpenApiSpecVersion.OpenApi2_0, OpenApiFormat.Json)] diff --git a/test/Microsoft.OpenApi.Tests/Models/OpenApiSchemaTests.cs b/test/Microsoft.OpenApi.Tests/Models/OpenApiSchemaTests.cs index 7965ef527..6a7155ed6 100644 --- a/test/Microsoft.OpenApi.Tests/Models/OpenApiSchemaTests.cs +++ b/test/Microsoft.OpenApi.Tests/Models/OpenApiSchemaTests.cs @@ -14,7 +14,6 @@ using Microsoft.OpenApi.Writers; using VerifyXunit; using Xunit; -using Xunit.Abstractions; namespace Microsoft.OpenApi.Tests.Models { @@ -219,13 +218,6 @@ public class OpenApiSchemaTests } }; - private readonly ITestOutputHelper _output; - - public OpenApiSchemaTests(ITestOutputHelper output) - { - _output = output; - } - [Fact] public void SerializeBasicSchemaAsV3JsonWorks() { diff --git a/test/Microsoft.OpenApi.Tests/Models/OpenApiSecuritySchemeTests.cs b/test/Microsoft.OpenApi.Tests/Models/OpenApiSecuritySchemeTests.cs index acb4323f1..d08d0a779 100644 --- a/test/Microsoft.OpenApi.Tests/Models/OpenApiSecuritySchemeTests.cs +++ b/test/Microsoft.OpenApi.Tests/Models/OpenApiSecuritySchemeTests.cs @@ -12,7 +12,6 @@ using Microsoft.OpenApi.Writers; using VerifyXunit; using Xunit; -using Xunit.Abstractions; namespace Microsoft.OpenApi.Tests.Models { @@ -121,13 +120,6 @@ public class OpenApiSecuritySchemeTests } }; - private readonly ITestOutputHelper _output; - - public OpenApiSecuritySchemeTests(ITestOutputHelper output) - { - _output = output; - } - [Fact] public void SerializeApiKeySecuritySchemeAsV3JsonWorks() { diff --git a/test/Microsoft.OpenApi.Tests/Services/OpenApiValidatorTests.cs b/test/Microsoft.OpenApi.Tests/Services/OpenApiValidatorTests.cs index 813cb9517..0342a3512 100644 --- a/test/Microsoft.OpenApi.Tests/Services/OpenApiValidatorTests.cs +++ b/test/Microsoft.OpenApi.Tests/Services/OpenApiValidatorTests.cs @@ -12,20 +12,12 @@ using Microsoft.OpenApi.Validations.Rules; using Microsoft.OpenApi.Writers; using Xunit; -using Xunit.Abstractions; namespace Microsoft.OpenApi.Tests.Services { [Collection("DefaultSettings")] public class OpenApiValidatorTests { - private readonly ITestOutputHelper _output; - - public OpenApiValidatorTests(ITestOutputHelper output) - { - _output = output; - } - [Fact] public void ResponseMustHaveADescription() { diff --git a/test/Microsoft.OpenApi.Tests/Validations/ValidationRuleSetTests.cs b/test/Microsoft.OpenApi.Tests/Validations/ValidationRuleSetTests.cs index 8153e6054..fcafaab21 100644 --- a/test/Microsoft.OpenApi.Tests/Validations/ValidationRuleSetTests.cs +++ b/test/Microsoft.OpenApi.Tests/Validations/ValidationRuleSetTests.cs @@ -2,19 +2,11 @@ // Licensed under the MIT license. using Xunit; -using Xunit.Abstractions; namespace Microsoft.OpenApi.Validations.Tests { public class ValidationRuleSetTests { - private readonly ITestOutputHelper _output; - - public ValidationRuleSetTests(ITestOutputHelper output) - { - _output = output; - } - [Fact] public void DefaultRuleSetReturnsTheCorrectRules() { diff --git a/test/Microsoft.OpenApi.Tests/Writers/OpenApiJsonWriterTests.cs b/test/Microsoft.OpenApi.Tests/Writers/OpenApiJsonWriterTests.cs index b7943916a..21b07bde1 100644 --- a/test/Microsoft.OpenApi.Tests/Writers/OpenApiJsonWriterTests.cs +++ b/test/Microsoft.OpenApi.Tests/Writers/OpenApiJsonWriterTests.cs @@ -11,20 +11,12 @@ using Microsoft.OpenApi.Writers; using Newtonsoft.Json; using Xunit; -using Xunit.Abstractions; namespace Microsoft.OpenApi.Tests.Writers { [Collection("DefaultSettings")] public class OpenApiJsonWriterTests { - private readonly ITestOutputHelper _output; - - public OpenApiJsonWriterTests(ITestOutputHelper output) - { - _output = output; - } - static bool[] shouldProduceTerseOutputValues = new[] { true, false }; public static IEnumerable WriteStringListAsJsonShouldMatchExpectedTestCases() diff --git a/test/Microsoft.OpenApi.Tests/Writers/OpenApiWriterSpecialCharacterTests.cs b/test/Microsoft.OpenApi.Tests/Writers/OpenApiWriterSpecialCharacterTests.cs index 6ac47d6c3..fcff726a0 100644 --- a/test/Microsoft.OpenApi.Tests/Writers/OpenApiWriterSpecialCharacterTests.cs +++ b/test/Microsoft.OpenApi.Tests/Writers/OpenApiWriterSpecialCharacterTests.cs @@ -8,20 +8,12 @@ using FluentAssertions; using Microsoft.OpenApi.Writers; using Xunit; -using Xunit.Abstractions; namespace Microsoft.OpenApi.Tests.Writers { [Collection("DefaultSettings")] public class OpenApiWriterSpecialCharacterTests { - private readonly ITestOutputHelper _output; - - public OpenApiWriterSpecialCharacterTests(ITestOutputHelper output) - { - _output = output; - } - static bool[] shouldProduceTerseOutputValues = new[] { true, false }; public static IEnumerable StringWithSpecialCharacters diff --git a/test/Microsoft.OpenApi.Tests/Writers/OpenApiYamlWriterTests.cs b/test/Microsoft.OpenApi.Tests/Writers/OpenApiYamlWriterTests.cs index cc5f82230..670e39c45 100644 --- a/test/Microsoft.OpenApi.Tests/Writers/OpenApiYamlWriterTests.cs +++ b/test/Microsoft.OpenApi.Tests/Writers/OpenApiYamlWriterTests.cs @@ -10,20 +10,12 @@ using Microsoft.OpenApi.Models; using Microsoft.OpenApi.Writers; using Xunit; -using Xunit.Abstractions; namespace Microsoft.OpenApi.Tests.Writers { [Collection("DefaultSettings")] public class OpenApiYamlWriterTests { - private readonly ITestOutputHelper _output; - - public OpenApiYamlWriterTests(ITestOutputHelper output) - { - _output = output; - } - public static IEnumerable WriteStringListAsYamlShouldMatchExpectedTestCases() { yield return new object[]