Abstract implementation detail from interface

Author: MaggieKimani1

src/Microsoft.OpenApi.Readers/OpenApiYamlReader.cs

@@ -21,6 +21,7 @@ namespace Microsoft.OpenApi.Readers
     public class OpenApiYamlReader : IOpenApiReader
     {
         private const int copyBufferSize = 4096;
+        private static readonly OpenApiJsonReader _jsonReader = new();
 
         /// <inheritdoc/>
         public async Task<ReadResult> ReadAsync(Stream input,
@@ -70,9 +71,9 @@ public ReadResult Read(MemoryStream input,
         }
 
         /// <inheritdoc/>
-        public ReadResult Read(JsonNode jsonNode, OpenApiReaderSettings settings, string format = null)
+        public static ReadResult Read(JsonNode jsonNode, OpenApiReaderSettings settings, string format = null)
         {
-            return OpenApiReaderRegistry.DefaultReader.Read(jsonNode, settings, OpenApiConstants.Yaml);
+            return _jsonReader.Read(jsonNode, settings, OpenApiConstants.Yaml);
         }
 
         /// <inheritdoc/>
@@ -101,9 +102,9 @@ public T ReadFragment<T>(MemoryStream input,
         }
 
         /// <inheritdoc/>
-        public T ReadFragment<T>(JsonNode input, OpenApiSpecVersion version, out OpenApiDiagnostic diagnostic, OpenApiReaderSettings settings = null) where T : IOpenApiElement
+        public static T ReadFragment<T>(JsonNode input, OpenApiSpecVersion version, out OpenApiDiagnostic diagnostic, OpenApiReaderSettings settings = null) where T : IOpenApiElement
         {
-            return OpenApiReaderRegistry.DefaultReader.ReadFragment<T>(input, version, out diagnostic, settings);
+            return _jsonReader.ReadFragment<T>(input, version, out diagnostic, settings);
         }
 
         /// <summary>

src/Microsoft.OpenApi/Interfaces/IOpenApiReader.cs

@@ -31,15 +31,6 @@ public interface IOpenApiReader
         /// <returns></returns>
         ReadResult Read(MemoryStream input, OpenApiReaderSettings settings);
 
-        /// <summary>
-        /// Parses the JsonNode input into an Open API document.
-        /// </summary>
-        /// <param name="jsonNode">The JsonNode input.</param>
-        /// <param name="settings">The Reader settings to be used during parsing.</param>
-        /// <param name="format">The OpenAPI format.</param>
-        /// <returns></returns>
-        ReadResult Read(JsonNode jsonNode, OpenApiReaderSettings settings, string format = null);
-
         /// <summary>
         /// Reads the MemoryStream and parses the fragment of an OpenAPI description into an Open API Element.
         /// </summary>
@@ -49,15 +40,5 @@ public interface IOpenApiReader
         /// <param name="settings">The OpenApiReader settings.</param>
         /// <returns>Instance of newly created IOpenApiElement.</returns>
         T ReadFragment<T>(MemoryStream input, OpenApiSpecVersion version, out OpenApiDiagnostic diagnostic, OpenApiReaderSettings settings = null) where T : IOpenApiElement;
-
-        /// <summary>
-        /// Reads the JsonNode input and parses the fragment of an OpenAPI description into an Open API Element.
-        /// </summary>
-        /// <param name="input">Memory stream containing OpenAPI description to parse.</param>
-        /// <param name="version">Version of the OpenAPI specification that the fragment conforms to.</param>
-        /// <param name="diagnostic">Returns diagnostic object containing errors detected during parsing.</param>
-        /// <param name="settings">The OpenApiReader settings.</param>
-        /// <returns>Instance of newly created IOpenApiElement.</returns>
-        T ReadFragment<T>(JsonNode input, OpenApiSpecVersion version, out OpenApiDiagnostic diagnostic, OpenApiReaderSettings settings = null) where T : IOpenApiElement;
     }
 }

test/Microsoft.OpenApi.Tests/PublicApi/PublicApi.approved.txt

@@ -220,12 +220,9 @@ namespace Microsoft.OpenApi.Interfaces
     public interface IOpenApiReader
     {
         Microsoft.OpenApi.Reader.ReadResult Read(System.IO.MemoryStream input, Microsoft.OpenApi.Reader.OpenApiReaderSettings settings);
-        Microsoft.OpenApi.Reader.ReadResult Read(System.Text.Json.Nodes.JsonNode jsonNode, Microsoft.OpenApi.Reader.OpenApiReaderSettings settings, string format = null);
         System.Threading.Tasks.Task<Microsoft.OpenApi.Reader.ReadResult> ReadAsync(System.IO.Stream input, Microsoft.OpenApi.Reader.OpenApiReaderSettings settings, System.Threading.CancellationToken cancellationToken = default);
         T ReadFragment<T>(System.IO.MemoryStream input, Microsoft.OpenApi.OpenApiSpecVersion version, out Microsoft.OpenApi.Reader.OpenApiDiagnostic diagnostic, Microsoft.OpenApi.Reader.OpenApiReaderSettings settings = null)
             where T : Microsoft.OpenApi.Interfaces.IOpenApiElement;
-        T ReadFragment<T>(System.Text.Json.Nodes.JsonNode input, Microsoft.OpenApi.OpenApiSpecVersion version, out Microsoft.OpenApi.Reader.OpenApiDiagnostic diagnostic, Microsoft.OpenApi.Reader.OpenApiReaderSettings settings = null)
-            where T : Microsoft.OpenApi.Interfaces.IOpenApiElement;
     }
     public interface IOpenApiReferenceable : Microsoft.OpenApi.Interfaces.IOpenApiElement, Microsoft.OpenApi.Interfaces.IOpenApiSerializable
     {