Merge pull request #2098 from microsoft/chore/additional-reference-inlining-tests

chore/additional reference inlining tests

Author: MaggieKimani1

src/Microsoft.OpenApi/Models/OpenApiReference.cs

@@ -158,11 +158,12 @@ public OpenApiReference(OpenApiReference reference)
         /// </summary>
         public void SerializeAsV31(IOpenApiWriter writer)
         {
-            // summary and description are in 3.1 but not in 3.0
-            writer.WriteProperty(OpenApiConstants.Summary, Summary);
-            writer.WriteProperty(OpenApiConstants.Description, Description);
-
-            SerializeInternal(writer);
+            SerializeInternal(writer, w =>
+            {
+                // summary and description are in 3.1 but not in 3.0
+                w.WriteProperty(OpenApiConstants.Summary, Summary);
+                w.WriteProperty(OpenApiConstants.Description, Description);
+            });
         }
 
         /// <summary>
@@ -176,7 +177,7 @@ public void SerializeAsV3(IOpenApiWriter writer)
         /// <summary>
         /// Serialize <see cref="OpenApiReference"/>
         /// </summary>
-        private void SerializeInternal(IOpenApiWriter writer)
+        private void SerializeInternal(IOpenApiWriter writer, Action<IOpenApiWriter> callback = null)
         {
             Utils.CheckArgumentNull(writer);
 
@@ -188,6 +189,10 @@ private void SerializeInternal(IOpenApiWriter writer)
             }
 
             writer.WriteStartObject();
+            if (callback is not null)
+            {
+                callback(writer);
+            }
 
             // $ref
             writer.WriteProperty(OpenApiConstants.DollarRef, ReferenceV3);

src/Microsoft.OpenApi/Models/References/BaseOpenApiReferenceHolder.cs

@@ -80,7 +80,7 @@ public void SerializeAsV3(IOpenApiWriter writer)
         }
         else
         {
-            SerializeInternal(writer, (writer, element) => CopyReferenceAsTargetElementWithOverrides(element).SerializeAsV3(writer));
+            SerializeInternal(writer, (writer, element) => element.SerializeAsV3(writer));
         }
     }
 
@@ -106,7 +106,7 @@ public virtual void SerializeAsV2(IOpenApiWriter writer)
         }
         else
         {
-            SerializeInternal(writer, (writer, element) => CopyReferenceAsTargetElementWithOverrides(element).SerializeAsV2(writer));
+            SerializeInternal(writer, (writer, element) => element.SerializeAsV2(writer));
         }
     }