chore: linting

Signed-off-by: Vincent Biret <[email protected]>

Author: baywet

src/Microsoft.OpenApi/Models/OpenApiReference.cs

@@ -2,7 +2,6 @@
 // Licensed under the MIT license.
 
 using System;
-using System.Collections.Generic;
 using System.Linq;
 using System.Text.Json.Nodes;
 using Microsoft.OpenApi.Reader;
@@ -165,7 +164,7 @@ public OpenApiReference(OpenApiReference reference)
         /// <summary>
         /// Serialize <see cref="OpenApiReference"/> to Open Api v3.1.
         /// </summary>
-        public void SerializeAsV31(IOpenApiWriter writer)
+        public virtual void SerializeAsV31(IOpenApiWriter writer)
         {
             SerializeInternal(writer, w =>
             {
@@ -178,7 +177,7 @@ public void SerializeAsV31(IOpenApiWriter writer)
         /// <summary>
         /// Serialize <see cref="OpenApiReference"/> to Open Api v3.0.
         /// </summary>
-        public void SerializeAsV3(IOpenApiWriter writer)
+        public virtual void SerializeAsV3(IOpenApiWriter writer)
         {
             SerializeInternal(writer);
         }
@@ -212,7 +211,7 @@ private void SerializeInternal(IOpenApiWriter writer, Action<IOpenApiWriter>? ca
         /// <summary>
         /// Serialize <see cref="OpenApiReference"/> to Open Api v2.0.
         /// </summary>
-        public void SerializeAsV2(IOpenApiWriter writer)
+        public virtual void SerializeAsV2(IOpenApiWriter writer)
         {
             Utils.CheckArgumentNull(writer);
 
@@ -296,7 +295,7 @@ internal void EnsureHostDocumentIsSet(OpenApiDocument currentDocument)
         }
         private static string? GetPropertyValueFromNode(JsonObject jsonObject, string key) =>
         jsonObject.TryGetPropertyValue(key, out var valueNode) && valueNode is JsonValue valueCast && valueCast.TryGetValue<string>(out var strValue) ? strValue : null;
-        internal void SetMetadataFromMapNode(MapNode mapNode)
+        internal virtual void SetMetadataFromMapNode(MapNode mapNode)
         {
             if (mapNode.JsonNode is not JsonObject jsonObject) return;
 

src/Microsoft.OpenApi/Models/OpenApiSchemaReferenceInformation.cs

@@ -72,7 +72,7 @@ public OpenApiSchemaReferenceInformation(OpenApiSchemaReferenceInformation refer
         /// <summary>
         /// Serialize <see cref="OpenApiSchemaReferenceInformation"/> to Open Api v3.1.
         /// </summary>
-        public new void SerializeAsV31(IOpenApiWriter writer)
+        public override void SerializeAsV31(IOpenApiWriter writer)
         {
             Utils.CheckArgumentNull(writer);
 
@@ -118,7 +118,7 @@ public OpenApiSchemaReferenceInformation(OpenApiSchemaReferenceInformation refer
         /// <summary>
         /// Sets metadata fields from a JSON node during parsing
         /// </summary>
-        internal new void SetMetadataFromMapNode(MapNode mapNode)
+        internal override void SetMetadataFromMapNode(MapNode mapNode)
         {
             base.SetMetadataFromMapNode(mapNode);
 
@@ -131,28 +131,19 @@ public OpenApiSchemaReferenceInformation(OpenApiSchemaReferenceInformation refer
             }
 
             // Boolean properties
-            if (jsonObject.TryGetPropertyValue(OpenApiConstants.Deprecated, out var deprecatedNode) && deprecatedNode is JsonValue deprecatedValue)
+            if (jsonObject.TryGetPropertyValue(OpenApiConstants.Deprecated, out var deprecatedNode) && deprecatedNode is JsonValue deprecatedValue && deprecatedValue.TryGetValue<bool>(out var deprecated))
             {
-                if (deprecatedValue.TryGetValue<bool>(out var deprecated))
-                {
-                    Deprecated = deprecated;
-                }
+                Deprecated = deprecated;
             }
 
-            if (jsonObject.TryGetPropertyValue(OpenApiConstants.ReadOnly, out var readOnlyNode) && readOnlyNode is JsonValue readOnlyValue)
+            if (jsonObject.TryGetPropertyValue(OpenApiConstants.ReadOnly, out var readOnlyNode) && readOnlyNode is JsonValue readOnlyValue && readOnlyValue.TryGetValue<bool>(out var readOnly))
             {
-                if (readOnlyValue.TryGetValue<bool>(out var readOnly))
-                {
-                    ReadOnly = readOnly;
-                }
+                ReadOnly = readOnly;
             }
 
-            if (jsonObject.TryGetPropertyValue(OpenApiConstants.WriteOnly, out var writeOnlyNode) && writeOnlyNode is JsonValue writeOnlyValue)
+            if (jsonObject.TryGetPropertyValue(OpenApiConstants.WriteOnly, out var writeOnlyNode) && writeOnlyNode is JsonValue writeOnlyValue && writeOnlyValue.TryGetValue<bool>(out var writeOnly))
             {
-                if (writeOnlyValue.TryGetValue<bool>(out var writeOnly))
-                {
-                    WriteOnly = writeOnly;
-                }
+                WriteOnly = writeOnly;
             }
 
             // Default value
@@ -178,4 +169,4 @@ public OpenApiSchemaReferenceInformation(OpenApiSchemaReferenceInformation refer
         private static string? GetPropertyValueFromNode(JsonObject jsonObject, string key) =>
             jsonObject.TryGetPropertyValue(key, out var valueNode) && valueNode is JsonValue valueCast && valueCast.TryGetValue<string>(out var strValue) ? strValue : null;
     }
-}
+}