Clean up code

Author: MaggieKimani1

src/Microsoft.OpenApi/Validations/Rules/OpenApiSchemaRules.cs

@@ -89,30 +89,28 @@ public static class OpenApiSchemaRules
         /// between other schemas which may satisfy the payload description.</param>
         public static bool ValidateChildSchemaAgainstDiscriminator(OpenApiSchema schema, string discriminatorName)
         {
-            bool containsDiscriminator = false;
-
             if (!schema.Required?.Contains(discriminatorName) ?? false)
             {
                 // recursively check nested schema.OneOf, schema.AnyOf or schema.AllOf and their required fields for the discriminator
                 if (schema.OneOf.Count != 0)
                 {
-                    return TraverseSchemaElements(discriminatorName, schema.OneOf, ref containsDiscriminator);
+                    return TraverseSchemaElements(discriminatorName, schema.OneOf);
                 }
                 if (schema.AnyOf.Count != 0)
                 {
-                    return TraverseSchemaElements(discriminatorName, schema.AnyOf, ref containsDiscriminator);
+                    return TraverseSchemaElements(discriminatorName, schema.AnyOf);
                 }
                 if (schema.AllOf.Count != 0)
                 {
-                    return TraverseSchemaElements(discriminatorName, schema.AllOf, ref containsDiscriminator);
+                    return TraverseSchemaElements(discriminatorName, schema.AllOf);
                 }
             }
             else
             {
                 return true;
             }
 
-            return containsDiscriminator;
+            return false;
         }
 
         /// <summary>
@@ -121,9 +119,8 @@ public static bool ValidateChildSchemaAgainstDiscriminator(OpenApiSchema schema,
         /// <param name="discriminatorName">Adds support for polymorphism. The discriminator is an object name that is used to differentiate
         /// between other schemas which may satisfy the payload description.</param>
         /// <param name="childSchema">The child schema.</param>
-        /// <param name="containsDiscriminator">Tracks whether the discriminator is present.</param>
         /// <returns></returns>
-        public static bool TraverseSchemaElements(string discriminatorName, IList<OpenApiSchema> childSchema, ref bool containsDiscriminator)
+        public static bool TraverseSchemaElements(string discriminatorName, IList<OpenApiSchema> childSchema)
         {
             foreach (var childItem in childSchema)
             {
@@ -134,11 +131,11 @@ public static bool TraverseSchemaElements(string discriminatorName, IList<OpenAp
                 }
                 else
                 {
-                    return containsDiscriminator = true;
+                    return true;
                 }
             }
 
-            return containsDiscriminator;
+            return false;
         }
     }
 }