Moved _inComponents logic into Walker

Author: darrelmiller

src/Microsoft.OpenApi/Services/OpenApiVisitorBase.cs

@@ -15,7 +15,6 @@ namespace Microsoft.OpenApi.Services
     public abstract class OpenApiVisitorBase
     {
         private readonly Stack<string> _path = new Stack<string>();
-        private bool _inComponents = false;
 
         /// <summary>
         /// Allow Rule to indicate validation error occured at a deeper context level.  
@@ -34,16 +33,6 @@ public void Exit()
             this._path.Pop();
         }
 
-        public void EnterComponents()
-        {
-            _inComponents = true;
-        }
-
-        public void ExitComponents()
-        {
-            _inComponents = false;
-        }
-
         /// <summary>
         /// Pointer to source of validation error in document
         /// </summary>
@@ -55,13 +44,7 @@ public string PathString
             }
         }
 
-        public bool InComponents
-        {
-            get
-            {
-                return _inComponents;
-            }
-        }
+    
 
         /// <summary>
         /// Visits <see cref="OpenApiDocument"/>

src/Microsoft.OpenApi/Services/OpenApiWalker.cs

@@ -18,6 +18,7 @@ public class OpenApiWalker
         private readonly OpenApiVisitorBase _visitor;
         private readonly Stack<OpenApiSchema> _schemaLoop = new Stack<OpenApiSchema>();
         private readonly Stack<OpenApiPathItem> _pathItemLoop = new Stack<OpenApiPathItem>();
+        private bool _inComponents = false;
 
         /// <summary>
         /// Initializes the <see cref="OpenApiWalker"/> class.
@@ -37,6 +38,9 @@ public void Walk(OpenApiDocument doc)
             {
                 return;
             }
+            _schemaLoop.Clear();
+            _pathItemLoop.Clear();
+            _inComponents = false;
 
             _visitor.Visit(doc);
 
@@ -96,7 +100,7 @@ internal void Walk(OpenApiComponents components)
                 return;
             }
 
-            _visitor.EnterComponents();
+            EnterComponents();
 
             _visitor.Visit(components);
 
@@ -194,7 +198,7 @@ internal void Walk(OpenApiComponents components)
             });
 
             Walk(components as IOpenApiExtensible);
-            _visitor.ExitComponents();
+            ExitComponents();
         }
 
         /// <summary>
@@ -1027,7 +1031,17 @@ private void Walk(string context, Action walk)
         /// </summary>
         private bool IsReference(IOpenApiReferenceable referenceable)
         {
-            return referenceable.Reference != null && !_visitor.InComponents;
+            return referenceable.Reference != null && !_inComponents;
+        }
+
+        private void EnterComponents()
+        {
+            _inComponents = true;
+        }
+
+        private void ExitComponents()
+        {
+            _inComponents = false;
         }
     }
 }