Merge pull request #1380 from SimonCropp/remove-some-duplicate-dictionary-lookups

remove some duplicate dictionary lookups

Author: baywet

src/Microsoft.OpenApi/Services/OpenApiUrlTreeNode.cs

@@ -58,12 +58,7 @@ public bool HasOperations(string label)
         {
             Utils.CheckArgumentNullOrEmpty(label, nameof(label));
 
-            if (!(PathItems?.ContainsKey(label) ?? false))
-            {
-                return false;
-            }
-
-            return PathItems[label].Operations?.Any() ?? false;
+            return PathItems is not null && PathItems.TryGetValue(label, out var item) && item.Operations is not null && item.Operations.Any();
         }
 
         /// <summary>
@@ -189,14 +184,15 @@ private OpenApiUrlTreeNode Attach(IEnumerable<string> segments,
             }
 
             // If the child segment has already been defined, then insert into it
-            if (Children.ContainsKey(segment))
+            if (Children.TryGetValue(segment, out var child))
             {
                 var newPath = currentPath + PathSeparator + segment;
 
-                return Children[segment].Attach(segments: segments.Skip(1),
-                                                pathItem: pathItem,
-                                                label: label,
-                                                currentPath: newPath);
+                return child.Attach(
+                    segments: segments.Skip(1),
+                    pathItem: pathItem,
+                    label: label,
+                    currentPath: newPath);
             }
             else
             {
@@ -226,14 +222,7 @@ public void AddAdditionalData(Dictionary<string, List<string>> additionalData)
 
             foreach (var item in additionalData)
             {
-                if (AdditionalData.ContainsKey(item.Key))
-                {
-                    AdditionalData[item.Key] = item.Value;
-                }
-                else
-                {
-                    AdditionalData.Add(item.Key, item.Value);
-                }
+                AdditionalData[item.Key] = item.Value;
             }
         }