chore: adds missing yaml reader to settings for base tests

baywet · baywet · commit 01398f0cbe71 · 2025-02-25T08:23:10.000-05:00
Signed-off-by: Vincent Biret &lt;vibiret@microsoft.com&gt;
diff --git a/test/Microsoft.OpenApi.Readers.Tests/ParseNodeTests.cs b/test/Microsoft.OpenApi.Readers.Tests/ParseNodeTests.cs
@@ -25,7 +25,7 @@ public void BrokenSimpleList()
                 paths: { }
                 """;
 
-            var result = OpenApiDocument.Parse(input, "yaml");
+            var result = OpenApiDocument.Parse(input, "yaml", SettingsFixture.ReaderSettings);
 
             Assert.Equivalent(new List<OpenApiError>() {
                 new OpenApiError(new OpenApiReaderException("Expected a value."))
@@ -51,7 +51,7 @@ public void BadSchema()
                                       schema: asdasd
                         """;
 
-            var res= OpenApiDocument.Parse(input, "yaml");
+            var res= OpenApiDocument.Parse(input, "yaml", SettingsFixture.ReaderSettings);
 
             Assert.Equivalent(new List<OpenApiError>
             {
diff --git a/test/Microsoft.OpenApi.Tests/Models/OpenApiDocumentTests.cs b/test/Microsoft.OpenApi.Tests/Models/OpenApiDocumentTests.cs
@@ -1682,7 +1682,7 @@ And reading in similar documents(one has a whitespace) yields the same hash code
 
         private static async Task<OpenApiDocument> ParseInputFileAsync(string filePath)
         {
-            var openApiDoc = (await OpenApiDocument.LoadAsync(filePath)).Document;
+            var openApiDoc = (await OpenApiDocument.LoadAsync(filePath, SettingsFixture.ReaderSettings)).Document;
             return openApiDoc;
         }
 
@@ -1985,7 +1985,7 @@ public async Task SerializeV31DocumentWithRefsInWebhooksWorks()
           items:
             type: object";
 
-            var doc = (await OpenApiDocument.LoadAsync("Models/Samples/docWithReusableWebhooks.yaml")).Document;
+            var doc = (await OpenApiDocument.LoadAsync("Models/Samples/docWithReusableWebhooks.yaml", SettingsFixture.ReaderSettings)).Document;
           
             var stringWriter = new StringWriter();
             var writer = new OpenApiYamlWriter(stringWriter, new OpenApiWriterSettings { InlineLocalReferences = true });
@@ -2039,7 +2039,7 @@ public async Task SerializeDocWithDollarIdInDollarRefSucceeds()
         radius:
           type: number
 ";
-            var doc = (await OpenApiDocument.LoadAsync("Models/Samples/docWithDollarId.yaml")).Document;
+            var doc = (await OpenApiDocument.LoadAsync("Models/Samples/docWithDollarId.yaml", SettingsFixture.ReaderSettings)).Document;
             var actual = await doc.SerializeAsYamlAsync(OpenApiSpecVersion.OpenApi3_1);
             Assert.Equal(expected.MakeLineBreaksEnvironmentNeutral(), actual.MakeLineBreaksEnvironmentNeutral());
         }
diff --git a/test/Microsoft.OpenApi.Tests/Models/References/OpenApiCallbackReferenceTests.cs b/test/Microsoft.OpenApi.Tests/Models/References/OpenApiCallbackReferenceTests.cs
@@ -132,8 +132,8 @@ public class OpenApiCallbackReferenceTests
 
         public OpenApiCallbackReferenceTests()
         {
-            OpenApiDocument openApiDoc = OpenApiDocument.Parse(OpenApi, OpenApiConstants.Yaml).Document;
-            OpenApiDocument openApiDoc_2 = OpenApiDocument.Parse(OpenApi_2, OpenApiConstants.Yaml).Document;
+            OpenApiDocument openApiDoc = OpenApiDocument.Parse(OpenApi, OpenApiConstants.Yaml, SettingsFixture.ReaderSettings).Document;
+            OpenApiDocument openApiDoc_2 = OpenApiDocument.Parse(OpenApi_2, OpenApiConstants.Yaml, SettingsFixture.ReaderSettings).Document;
             openApiDoc.Workspace.AddDocumentId("https://myserver.com/beta", openApiDoc_2.BaseUri);
             openApiDoc.Workspace.RegisterComponents(openApiDoc_2);
             _externalCallbackReference = new("callbackEvent", openApiDoc, "https://myserver.com/beta");
diff --git a/test/Microsoft.OpenApi.Tests/Models/References/OpenApiExampleReferenceTests.cs b/test/Microsoft.OpenApi.Tests/Models/References/OpenApiExampleReferenceTests.cs
@@ -111,8 +111,8 @@ public class OpenApiExampleReferenceTests
 
         public OpenApiExampleReferenceTests()
         {
-            _openApiDoc = OpenApiDocument.Parse(OpenApi, OpenApiConstants.Yaml).Document;
-            _openApiDoc_2 = OpenApiDocument.Parse(OpenApi_2, OpenApiConstants.Yaml).Document;
+            _openApiDoc = OpenApiDocument.Parse(OpenApi, OpenApiConstants.Yaml, SettingsFixture.ReaderSettings).Document;
+            _openApiDoc_2 = OpenApiDocument.Parse(OpenApi_2, OpenApiConstants.Yaml, SettingsFixture.ReaderSettings).Document;
             _openApiDoc.Workspace.AddDocumentId("https://myserver.com/beta", _openApiDoc_2.BaseUri);
             _openApiDoc.Workspace.RegisterComponents(_openApiDoc_2);
 
diff --git a/test/Microsoft.OpenApi.Tests/Models/References/OpenApiHeaderReferenceTests.cs b/test/Microsoft.OpenApi.Tests/Models/References/OpenApiHeaderReferenceTests.cs
@@ -80,8 +80,8 @@ public class OpenApiHeaderReferenceTests
 
         public OpenApiHeaderReferenceTests()
         {
-            _openApiDoc = OpenApiDocument.Parse(OpenApi, OpenApiConstants.Yaml).Document;
-            _openApiDoc_2 = OpenApiDocument.Parse(OpenApi_2, OpenApiConstants.Yaml).Document;
+            _openApiDoc = OpenApiDocument.Parse(OpenApi, OpenApiConstants.Yaml, SettingsFixture.ReaderSettings).Document;
+            _openApiDoc_2 = OpenApiDocument.Parse(OpenApi_2, OpenApiConstants.Yaml, SettingsFixture.ReaderSettings).Document;
             _openApiDoc.Workspace.AddDocumentId("https://myserver.com/beta", _openApiDoc_2.BaseUri);
             _openApiDoc.Workspace.RegisterComponents(_openApiDoc_2);
 
diff --git a/test/Microsoft.OpenApi.Tests/Models/References/OpenApiLinkReferenceTests.cs b/test/Microsoft.OpenApi.Tests/Models/References/OpenApiLinkReferenceTests.cs
@@ -123,8 +123,8 @@ public class OpenApiLinkReferenceTests
 
         public OpenApiLinkReferenceTests()
         {
-            _openApiDoc = OpenApiDocument.Parse(OpenApi, OpenApiConstants.Yaml).Document;
-            _openApiDoc_2 = OpenApiDocument.Parse(OpenApi_2, OpenApiConstants.Yaml).Document;
+            _openApiDoc = OpenApiDocument.Parse(OpenApi, OpenApiConstants.Yaml, SettingsFixture.ReaderSettings).Document;
+            _openApiDoc_2 = OpenApiDocument.Parse(OpenApi_2, OpenApiConstants.Yaml, SettingsFixture.ReaderSettings).Document;
             _openApiDoc.Workspace.AddDocumentId("https://myserver.com/beta", _openApiDoc_2.BaseUri);
             _openApiDoc.Workspace.RegisterComponents(_openApiDoc_2);
 
diff --git a/test/Microsoft.OpenApi.Tests/Models/References/OpenApiParameterReferenceTests.cs b/test/Microsoft.OpenApi.Tests/Models/References/OpenApiParameterReferenceTests.cs
@@ -81,8 +81,8 @@ public class OpenApiParameterReferenceTests
 
         public OpenApiParameterReferenceTests()
         {
-            _openApiDoc = OpenApiDocument.Parse(OpenApi, OpenApiConstants.Yaml).Document;
-            _openApiDoc_2 = OpenApiDocument.Parse(OpenApi_2, OpenApiConstants.Yaml).Document;
+            _openApiDoc = OpenApiDocument.Parse(OpenApi, OpenApiConstants.Yaml, SettingsFixture.ReaderSettings).Document;
+            _openApiDoc_2 = OpenApiDocument.Parse(OpenApi_2, OpenApiConstants.Yaml, SettingsFixture.ReaderSettings).Document;
             _openApiDoc.Workspace.AddDocumentId("https://myserver.com/beta", _openApiDoc_2.BaseUri);
             _openApiDoc.Workspace.RegisterComponents(_openApiDoc_2);
 
diff --git a/test/Microsoft.OpenApi.Tests/Models/References/OpenApiPathItemReferenceTests.cs b/test/Microsoft.OpenApi.Tests/Models/References/OpenApiPathItemReferenceTests.cs
@@ -78,8 +78,8 @@ public class OpenApiPathItemReferenceTests
 
         public OpenApiPathItemReferenceTests()
         {
-            _openApiDoc = OpenApiDocument.Parse(OpenApi, OpenApiConstants.Yaml).Document;
-            _openApiDoc_2 = OpenApiDocument.Parse(OpenApi_2, OpenApiConstants.Yaml).Document;
+            _openApiDoc = OpenApiDocument.Parse(OpenApi, OpenApiConstants.Yaml, SettingsFixture.ReaderSettings).Document;
+            _openApiDoc_2 = OpenApiDocument.Parse(OpenApi_2, OpenApiConstants.Yaml, SettingsFixture.ReaderSettings).Document;
             _openApiDoc.Workspace.AddDocumentId("https://myserver.com/beta", _openApiDoc_2.BaseUri);
             _openApiDoc.Workspace.RegisterComponents(_openApiDoc_2);
             _openApiDoc_2.Workspace.RegisterComponents(_openApiDoc_2);
diff --git a/test/Microsoft.OpenApi.Tests/Models/References/OpenApiRequestBodyReferenceTests.cs b/test/Microsoft.OpenApi.Tests/Models/References/OpenApiRequestBodyReferenceTests.cs
@@ -86,8 +86,8 @@ public class OpenApiRequestBodyReferenceTests
 
         public OpenApiRequestBodyReferenceTests()
         {
-            _openApiDoc = OpenApiDocument.Parse(OpenApi, OpenApiConstants.Yaml).Document;
-            _openApiDoc_2 = OpenApiDocument.Parse(OpenApi_2, OpenApiConstants.Yaml).Document;
+            _openApiDoc = OpenApiDocument.Parse(OpenApi, OpenApiConstants.Yaml, SettingsFixture.ReaderSettings).Document;
+            _openApiDoc_2 = OpenApiDocument.Parse(OpenApi_2, OpenApiConstants.Yaml, SettingsFixture.ReaderSettings).Document;
             _openApiDoc.Workspace.AddDocumentId("https://myserver.com/beta", _openApiDoc_2.BaseUri);
             _openApiDoc.Workspace.RegisterComponents(_openApiDoc_2);
 
diff --git a/test/Microsoft.OpenApi.Tests/Models/References/OpenApiResponseReferenceTest.cs b/test/Microsoft.OpenApi.Tests/Models/References/OpenApiResponseReferenceTest.cs
@@ -69,8 +69,8 @@ public class OpenApiResponseReferenceTest
 
         public OpenApiResponseReferenceTest()
         {
-            _openApiDoc = OpenApiDocument.Parse(OpenApi, OpenApiConstants.Yaml).Document;
-            _openApiDoc_2 = OpenApiDocument.Parse(OpenApi_2, OpenApiConstants.Yaml).Document;
+            _openApiDoc = OpenApiDocument.Parse(OpenApi, OpenApiConstants.Yaml, SettingsFixture.ReaderSettings).Document;
+            _openApiDoc_2 = OpenApiDocument.Parse(OpenApi_2, OpenApiConstants.Yaml, SettingsFixture.ReaderSettings).Document;
             _openApiDoc.Workspace.AddDocumentId("https://myserver.com/beta", _openApiDoc_2.BaseUri);
             _openApiDoc.Workspace.RegisterComponents(_openApiDoc_2);
 
diff --git a/test/Microsoft.OpenApi.Tests/Models/References/OpenApiSecuritySchemeReferenceTests.cs b/test/Microsoft.OpenApi.Tests/Models/References/OpenApiSecuritySchemeReferenceTests.cs
@@ -43,7 +43,7 @@ public class OpenApiSecuritySchemeReferenceTests
 
         public OpenApiSecuritySchemeReferenceTests()
         {
-            var result = OpenApiDocument.Parse(OpenApi, "yaml");
+            var result = OpenApiDocument.Parse(OpenApi, "yaml", SettingsFixture.ReaderSettings);
             _openApiSecuritySchemeReference = new("mySecurityScheme", result.Document);
         }
 
diff --git a/test/Microsoft.OpenApi.Tests/Models/References/OpenApiTagReferenceTest.cs b/test/Microsoft.OpenApi.Tests/Models/References/OpenApiTagReferenceTest.cs
@@ -63,7 +63,7 @@ public class OpenApiTagReferenceTest
 
         public OpenApiTagReferenceTest()
         {
-            var result = OpenApiDocument.Parse(OpenApi, "yaml");
+            var result = OpenApiDocument.Parse(OpenApi, "yaml", SettingsFixture.ReaderSettings);
             _openApiTagReference = new("user", result.Document);
         }
 
diff --git a/test/Microsoft.OpenApi.Tests/SettingsFixture.cs b/test/Microsoft.OpenApi.Tests/SettingsFixture.cs
@@ -0,0 +1,7 @@
+using Microsoft.OpenApi.Reader;
+
+namespace Microsoft.OpenApi.Tests;
+public static class SettingsFixture
+{
+    public static OpenApiReaderSettings ReaderSettings { get { var settings = new OpenApiReaderSettings(); settings.AddYamlReader() ; return settings; } }
+}

Original file line number	Diff line number	Diff line change
`@@ -111,8 +111,8 @@ public class OpenApiExampleReferenceTests`
`111`	`111`
`112`	`112`	`public OpenApiExampleReferenceTests()`
`113`	`113`	`{`
`114`		`- _openApiDoc = OpenApiDocument.Parse(OpenApi, OpenApiConstants.Yaml).Document;`
`115`		`- _openApiDoc_2 = OpenApiDocument.Parse(OpenApi_2, OpenApiConstants.Yaml).Document;`
	`114`	`+ _openApiDoc = OpenApiDocument.Parse(OpenApi, OpenApiConstants.Yaml, SettingsFixture.ReaderSettings).Document;`
	`115`	`+ _openApiDoc_2 = OpenApiDocument.Parse(OpenApi_2, OpenApiConstants.Yaml, SettingsFixture.ReaderSettings).Document;`
`116`	`116`	`_openApiDoc.Workspace.AddDocumentId("https://myserver.com/beta", _openApiDoc_2.BaseUri);`
`117`	`117`	`_openApiDoc.Workspace.RegisterComponents(_openApiDoc_2);`
`118`	`118`
Original file line number	Diff line number	Diff line change
`@@ -80,8 +80,8 @@ public class OpenApiHeaderReferenceTests`
`80`	`80`
`81`	`81`	`public OpenApiHeaderReferenceTests()`
`82`	`82`	`{`
`83`		`- _openApiDoc = OpenApiDocument.Parse(OpenApi, OpenApiConstants.Yaml).Document;`
`84`		`- _openApiDoc_2 = OpenApiDocument.Parse(OpenApi_2, OpenApiConstants.Yaml).Document;`
	`83`	`+ _openApiDoc = OpenApiDocument.Parse(OpenApi, OpenApiConstants.Yaml, SettingsFixture.ReaderSettings).Document;`
	`84`	`+ _openApiDoc_2 = OpenApiDocument.Parse(OpenApi_2, OpenApiConstants.Yaml, SettingsFixture.ReaderSettings).Document;`
`85`	`85`	`_openApiDoc.Workspace.AddDocumentId("https://myserver.com/beta", _openApiDoc_2.BaseUri);`
`86`	`86`	`_openApiDoc.Workspace.RegisterComponents(_openApiDoc_2);`
`87`	`87`
Original file line number	Diff line number	Diff line change
`@@ -123,8 +123,8 @@ public class OpenApiLinkReferenceTests`
`123`	`123`
`124`	`124`	`public OpenApiLinkReferenceTests()`
`125`	`125`	`{`
`126`		`- _openApiDoc = OpenApiDocument.Parse(OpenApi, OpenApiConstants.Yaml).Document;`
`127`		`- _openApiDoc_2 = OpenApiDocument.Parse(OpenApi_2, OpenApiConstants.Yaml).Document;`
	`126`	`+ _openApiDoc = OpenApiDocument.Parse(OpenApi, OpenApiConstants.Yaml, SettingsFixture.ReaderSettings).Document;`
	`127`	`+ _openApiDoc_2 = OpenApiDocument.Parse(OpenApi_2, OpenApiConstants.Yaml, SettingsFixture.ReaderSettings).Document;`
`128`	`128`	`_openApiDoc.Workspace.AddDocumentId("https://myserver.com/beta", _openApiDoc_2.BaseUri);`
`129`	`129`	`_openApiDoc.Workspace.RegisterComponents(_openApiDoc_2);`
`130`	`130`
Original file line number	Diff line number	Diff line change
`@@ -81,8 +81,8 @@ public class OpenApiParameterReferenceTests`
`81`	`81`
`82`	`82`	`public OpenApiParameterReferenceTests()`
`83`	`83`	`{`
`84`		`- _openApiDoc = OpenApiDocument.Parse(OpenApi, OpenApiConstants.Yaml).Document;`
`85`		`- _openApiDoc_2 = OpenApiDocument.Parse(OpenApi_2, OpenApiConstants.Yaml).Document;`
	`84`	`+ _openApiDoc = OpenApiDocument.Parse(OpenApi, OpenApiConstants.Yaml, SettingsFixture.ReaderSettings).Document;`
	`85`	`+ _openApiDoc_2 = OpenApiDocument.Parse(OpenApi_2, OpenApiConstants.Yaml, SettingsFixture.ReaderSettings).Document;`
`86`	`86`	`_openApiDoc.Workspace.AddDocumentId("https://myserver.com/beta", _openApiDoc_2.BaseUri);`
`87`	`87`	`_openApiDoc.Workspace.RegisterComponents(_openApiDoc_2);`
`88`	`88`
Original file line number	Diff line number	Diff line change
`@@ -86,8 +86,8 @@ public class OpenApiRequestBodyReferenceTests`
`86`	`86`
`87`	`87`	`public OpenApiRequestBodyReferenceTests()`
`88`	`88`	`{`
`89`		`- _openApiDoc = OpenApiDocument.Parse(OpenApi, OpenApiConstants.Yaml).Document;`
`90`		`- _openApiDoc_2 = OpenApiDocument.Parse(OpenApi_2, OpenApiConstants.Yaml).Document;`
	`89`	`+ _openApiDoc = OpenApiDocument.Parse(OpenApi, OpenApiConstants.Yaml, SettingsFixture.ReaderSettings).Document;`
	`90`	`+ _openApiDoc_2 = OpenApiDocument.Parse(OpenApi_2, OpenApiConstants.Yaml, SettingsFixture.ReaderSettings).Document;`
`91`	`91`	`_openApiDoc.Workspace.AddDocumentId("https://myserver.com/beta", _openApiDoc_2.BaseUri);`
`92`	`92`	`_openApiDoc.Workspace.RegisterComponents(_openApiDoc_2);`
`93`	`93`
Original file line number	Diff line number	Diff line change
`@@ -69,8 +69,8 @@ public class OpenApiResponseReferenceTest`
`69`	`69`
`70`	`70`	`public OpenApiResponseReferenceTest()`
`71`	`71`	`{`
`72`		`- _openApiDoc = OpenApiDocument.Parse(OpenApi, OpenApiConstants.Yaml).Document;`
`73`		`- _openApiDoc_2 = OpenApiDocument.Parse(OpenApi_2, OpenApiConstants.Yaml).Document;`
	`72`	`+ _openApiDoc = OpenApiDocument.Parse(OpenApi, OpenApiConstants.Yaml, SettingsFixture.ReaderSettings).Document;`
	`73`	`+ _openApiDoc_2 = OpenApiDocument.Parse(OpenApi_2, OpenApiConstants.Yaml, SettingsFixture.ReaderSettings).Document;`
`74`	`74`	`_openApiDoc.Workspace.AddDocumentId("https://myserver.com/beta", _openApiDoc_2.BaseUri);`
`75`	`75`	`_openApiDoc.Workspace.RegisterComponents(_openApiDoc_2);`
`76`	`76`