From 139b3be425a112201c05619a4bef4f239f4a9581 Mon Sep 17 00:00:00 2001 From: Shruthi42 <13177030+Shruthi42@users.noreply.github.com> Date: Thu, 26 Aug 2021 09:39:19 +0100 Subject: [PATCH 1/2] Fix learning_rate parameter name --- InnerEye/ML/SSL/lightning_containers/ssl_container.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/InnerEye/ML/SSL/lightning_containers/ssl_container.py b/InnerEye/ML/SSL/lightning_containers/ssl_container.py index 6ad2bda8c..4754738d1 100644 --- a/InnerEye/ML/SSL/lightning_containers/ssl_container.py +++ b/InnerEye/ML/SSL/lightning_containers/ssl_container.py @@ -149,7 +149,7 @@ def create_model(self) -> LightningModule: gpus=self.total_num_gpus, num_samples=self.data_module.num_samples, batch_size=self.data_module.batch_size, - lr=self.l_rate, + learning_rate=self.l_rate, max_epochs=self.num_epochs) elif self.ssl_training_type == SSLTrainingType.BYOL: model = BYOLInnerEye(encoder_name=self.ssl_encoder.value, From 497746c5b6db0b9c832a5a181ea803c7d4b4a16e Mon Sep 17 00:00:00 2001 From: Shruthi42 <13177030+Shruthi42@users.noreply.github.com> Date: Thu, 26 Aug 2021 11:53:34 +0100 Subject: [PATCH 2/2] Update CHANGELOG.md --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 141d7f0e6..ecbb44671 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -62,6 +62,8 @@ mounting and running matplotblib on some machines. Re-instantiated a disabled te - ([#509](https://github.com/microsoft/InnerEye-DeepLearning/pull/509)) Fix issue where model checkpoints were not loaded in inference-only runs when using lightning containers. - ([#553](https://github.com/microsoft/InnerEye-DeepLearning/pull/553)) Fix incomplete test data module setup in Lightning inference. +- ([#557](https://github.com/microsoft/InnerEye-DeepLearning/pull/557)) Fix issue where learning rate was not set + correctly in the SimCLR module ### Removed