From 0dfff15cd323ac9b2456338db178ec9a739181b9 Mon Sep 17 00:00:00 2001 From: Matthew Metcalf Date: Tue, 28 Oct 2025 18:22:12 -0700 Subject: [PATCH 1/4] Disable pylint warning for unused argument Add pylint disable comment for unused argument in on_start method. --- featuremanagement/azuremonitor/_send_telemetry.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/featuremanagement/azuremonitor/_send_telemetry.py b/featuremanagement/azuremonitor/_send_telemetry.py index 2e8f6ea..ac6f074 100644 --- a/featuremanagement/azuremonitor/_send_telemetry.py +++ b/featuremanagement/azuremonitor/_send_telemetry.py @@ -127,7 +127,7 @@ def __init__(self, **kwargs: Any) -> None: "targeting_context_accessor", None ) - def on_start(self, span: Span, parent_context: Optional[Context] = None) -> None: + def on_start(self, span: Span, parent_context: Optional[Context] = None) -> None: # pylint: disable=unused-argument """ Attaches the targeting ID to the span and baggage when a new span is started. From 5f613e4dd64e420451def98c34ee6afb84b0314b Mon Sep 17 00:00:00 2001 From: Matt Metcalf Date: Tue, 28 Oct 2025 18:24:52 -0700 Subject: [PATCH 2/4] Update _send_telemetry.py --- featuremanagement/azuremonitor/_send_telemetry.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/featuremanagement/azuremonitor/_send_telemetry.py b/featuremanagement/azuremonitor/_send_telemetry.py index ac6f074..0a7f727 100644 --- a/featuremanagement/azuremonitor/_send_telemetry.py +++ b/featuremanagement/azuremonitor/_send_telemetry.py @@ -127,7 +127,7 @@ def __init__(self, **kwargs: Any) -> None: "targeting_context_accessor", None ) - def on_start(self, span: Span, parent_context: Optional[Context] = None) -> None: # pylint: disable=unused-argument + def on_start(self, span: Span, parent_context: Optional[Context] = None) -> None: # pylint: disable=unused-argument """ Attaches the targeting ID to the span and baggage when a new span is started. From b962771155ff8b6dd9f58fdb18750e0e13547048 Mon Sep 17 00:00:00 2001 From: Matt Metcalf Date: Tue, 28 Oct 2025 18:30:40 -0700 Subject: [PATCH 3/4] Update feature_variant_sample_with_targeting_accessor.py --- samples/feature_variant_sample_with_targeting_accessor.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/samples/feature_variant_sample_with_targeting_accessor.py b/samples/feature_variant_sample_with_targeting_accessor.py index 481642c..a381d46 100644 --- a/samples/feature_variant_sample_with_targeting_accessor.py +++ b/samples/feature_variant_sample_with_targeting_accessor.py @@ -16,11 +16,11 @@ with open(script_directory + "/formatted_feature_flags.json", "r", encoding="utf-8") as f: feature_flags = json.load(f) -USER_ID = "Adam" +user_id = "Adam" def my_targeting_accessor() -> TargetingContext: - return TargetingContext(user_id=USER_ID) + return TargetingContext(user_id=user_id) feature_manager = FeatureManager( @@ -30,7 +30,7 @@ def my_targeting_accessor() -> TargetingContext: print(feature_manager.is_enabled("TestVariants")) print(feature_manager.get_variant("TestVariants").configuration) -USER_ID = "Ellie" +user_id = "Ellie" print(feature_manager.is_enabled("TestVariants")) print(feature_manager.get_variant("TestVariants").configuration) From 9e3fcc4f740a22eaf5c6abee3940a4cd7edfa1e4 Mon Sep 17 00:00:00 2001 From: Matt Metcalf Date: Tue, 28 Oct 2025 18:39:51 -0700 Subject: [PATCH 4/4] Update feature_variant_sample_with_targeting_accessor.py --- samples/feature_variant_sample_with_targeting_accessor.py | 1 + 1 file changed, 1 insertion(+) diff --git a/samples/feature_variant_sample_with_targeting_accessor.py b/samples/feature_variant_sample_with_targeting_accessor.py index a381d46..079957a 100644 --- a/samples/feature_variant_sample_with_targeting_accessor.py +++ b/samples/feature_variant_sample_with_targeting_accessor.py @@ -16,6 +16,7 @@ with open(script_directory + "/formatted_feature_flags.json", "r", encoding="utf-8") as f: feature_flags = json.load(f) +# pylint: disable=invalid-name user_id = "Adam"