Validation tests (#20)

* Fixing issues found when targeting users

* Adding some comments and fixing a few tests

* Updated Theta test description

* removing debug steps

* Split file into multiple

* Cleaning Up

* removed old file

* More tests, fixed default enabled value.

* Enabled should be a boolean

* Update test_no_filters_from_file.py

* Updated to json tests

* formatting

* Map to list

* Update test_json_validations.py

* Updated from changes in App Config repo

* Updating with PyLint

* Update test_json_validations.py

* Updated to match AppConfiguration repo

* Trying out submodule

* Delete --force

* Update TestFiles

* Removing submodule

* Updating Tests

* single quotes

* single quotes in tests

* Updated schema

* Updated to fix tests

* Update _defaultfilters.py

Author: mrm9084

featuremanagement/_defaultfilters.py

@@ -92,9 +92,7 @@ def _target_group(self, target_user, target_group, group, feature_flag_name):
         group_rollout_percentage = group.get(ROLLOUT_PERCENTAGE_KEY, 0)
         if not target_user:
             target_user = ""
-        audience_context_id = (
-            target_user + "\n" + target_group + "\n" + feature_flag_name + "\n" + group.get(FEATURE_FILTER_NAME_KEY, "")
-        )
+        audience_context_id = target_user + "\n" + feature_flag_name + "\n" + target_group
 
         return self._is_targeted(audience_context_id, group_rollout_percentage)
 

featuremanagement/_models/_feature_flag.py

@@ -41,7 +41,7 @@ def convert_from_json(cls, json_value):
         if not isinstance(json_value, dict):
             raise ValueError("Feature flag must be a dictionary.")
         feature_flag._id = json_value.get(FEATURE_FLAG_ID)
-        feature_flag._enabled = _convert_boolean_value(json_value.get(FEATURE_FLAG_ENABLED, True))
+        feature_flag._enabled = _convert_boolean_value(json_value.get(FEATURE_FLAG_ENABLED, False))
         feature_flag._conditions = FeatureConditions.convert_from_json(
             feature_flag._id, json_value.get(FEATURE_FLAG_CONDITIONS, {})
         )
@@ -115,9 +115,9 @@ def variants(self):
 
     def _validate(self):
         if not isinstance(self._id, str):
-            raise ValueError("Feature flag id field must be a string.")
+            raise ValueError(f"Invalid setting 'id' with value '{self._id}' for feature '{self._id}'.")
         if not isinstance(self._enabled, bool):
-            raise ValueError(f"Feature flag {self._id} must be a boolean.")
+            raise ValueError(f"Invalid setting 'enabled' with value '{self._enabled}' for feature '{self._id}'.")
         self.conditions._validate(self._id)  # pylint: disable=protected-access