Skip to content

Commit bd32c17

Browse files
authored
Disable pylint warning for unused argument (#60)
* Disable pylint warning for unused argument Add pylint disable comment for unused argument in on_start method. * Update _send_telemetry.py * Update feature_variant_sample_with_targeting_accessor.py * Update feature_variant_sample_with_targeting_accessor.py
1 parent 4a88b06 commit bd32c17

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

featuremanagement/azuremonitor/_send_telemetry.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ def __init__(self, **kwargs: Any) -> None:
127127
"targeting_context_accessor", None
128128
)
129129

130-
def on_start(self, span: Span, parent_context: Optional[Context] = None) -> None:
130+
def on_start(self, span: Span, parent_context: Optional[Context] = None) -> None: # pylint: disable=unused-argument
131131
"""
132132
Attaches the targeting ID to the span and baggage when a new span is started.
133133

samples/feature_variant_sample_with_targeting_accessor.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,12 @@
1616
with open(script_directory + "/formatted_feature_flags.json", "r", encoding="utf-8") as f:
1717
feature_flags = json.load(f)
1818

19-
USER_ID = "Adam"
19+
# pylint: disable=invalid-name
20+
user_id = "Adam"
2021

2122

2223
def my_targeting_accessor() -> TargetingContext:
23-
return TargetingContext(user_id=USER_ID)
24+
return TargetingContext(user_id=user_id)
2425

2526

2627
feature_manager = FeatureManager(
@@ -30,7 +31,7 @@ def my_targeting_accessor() -> TargetingContext:
3031
print(feature_manager.is_enabled("TestVariants"))
3132
print(feature_manager.get_variant("TestVariants").configuration)
3233

33-
USER_ID = "Ellie"
34+
user_id = "Ellie"
3435

3536
print(feature_manager.is_enabled("TestVariants"))
3637
print(feature_manager.get_variant("TestVariants").configuration)

0 commit comments

Comments
 (0)