Skip to content

Updates test/comment schema and adjusts schema title #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Updates test/comment schema and adjusts schema title #372

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion schemas/FeatureManagement.Dotnet.v1.0.0.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"definitions": {},
"$schema": "http://json-schema.org/draft-07/schema#",
"type": "object",
"title": "The .NET Feature Management Schema",
Copy link
Member Author

@rossgrambo rossgrambo Feb 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title describes this object- not the file. See https://json-schema.org/learn/json-schema-examples

Copy link
Member

@jimmyca15 jimmyca15 Feb 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhiyuanliang-ms I think I suggested this title, but it looks like Ross is right here.

"title": "A .NET Feature Management Configuration",
"required": [],
"patternProperties": {
"^[^:]*$": {
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.FeatureManagement/ConfigurationFeatureDefinitionProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ We support
enabledFor: false
},
myAllRequiredFilterFeature: {
requirementType: "all",
requirementType: "All",
enabledFor: [{name: "myFeatureFilter1"}, {name: "myFeatureFilter2"}]
}

Expand Down
4 changes: 2 additions & 2 deletions tests/Tests.FeatureManagement/appsettings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"OnTestFeature": true,
"OffTestFeature": false,
"FeatureUsesFiltersWithDuplicatedAlias": {
"RequirementType": "all",
"RequirementType": "All",
"EnabledFor": [
{
"Name": "DuplicatedFilterName"
Expand Down Expand Up @@ -145,7 +145,7 @@
]
},
"AllFilterFeature": {
"RequirementType": "all",
"RequirementType": "All",
"EnabledFor": [
{
"Name": "Test",
Expand Down