Support Microsoft Feature Management schema for preview branch #356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhiyuanliang-ms
requested review from
amerjusupovic,
jimmyca15 and
rossgrambo
jimmyca15
assigned
jimmyca15,
amerjusupovic and
rossgrambo and unassigned
jimmyca15 and
amerjusupovic
rossgrambo
reviewed
Feb 16, 2024
| // Microsoft feature flag schema: https://github.com/Azure/AppConfiguration/blob/main/docs/FeatureManagement/FeatureFlag.v2.0.0.schema.json | ||
| internal static class MicrosoftFeatureFlagFields | ||
| { | ||
| public const string FeatureFlagsSectionName = "FeatureFlags"; |
Member
There was a problem hiding this comment.
Lets add support for "feature_flags" & "feature_management" as well here.
Member
Author
There was a problem hiding this comment.
I think we should only support snake casing for Microsoft Feature Management schema.
@jimmyca15
Member
There was a problem hiding this comment.
The rest of this file is snake case, but perhaps I'm misunderstanding how this file is used?
*I now see the updated PR
zhiyuanliang-ms
changed the title
zhiyuanliang-ms
deleted the
zhiyuanliang/support-microsoft-schema-for-preview
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up #319
Support Microsoft Feature Flag schema v2.0.0