Skip to content

Commit 1f3eca4

Browse files
update (#400)
1 parent 5c34b8c commit 1f3eca4

File tree

3 files changed

+3
-12
lines changed

3 files changed

+3
-12
lines changed

src/Microsoft.FeatureManagement/FeatureFilters/PercentageFilter.cs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -51,10 +51,7 @@ public Task<bool> EvaluateAsync(FeatureFilterEvaluationContext context)
5151

5252
if (settings.Value < 0)
5353
{
54-
if (_logger != null)
55-
{
56-
_logger.LogWarning($"The '{Alias}' feature filter does not have a valid '{nameof(settings.Value)}' value for feature '{context.FeatureName}'");
57-
}
54+
_logger?.LogWarning($"The '{Alias}' feature filter does not have a valid '{nameof(settings.Value)}' value for feature '{context.FeatureName}'");
5855

5956
result = false;
6057
}

src/Microsoft.FeatureManagement/FeatureFilters/TimeWindowFilter.cs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -51,10 +51,7 @@ public Task<bool> EvaluateAsync(FeatureFilterEvaluationContext context)
5151

5252
if (!settings.Start.HasValue && !settings.End.HasValue)
5353
{
54-
if (_logger != null)
55-
{
56-
_logger.LogWarning($"The '{Alias}' feature filter is not valid for feature '{context.FeatureName}'. It must have have specify either '{nameof(settings.Start)}', '{nameof(settings.End)}', or both.");
57-
}
54+
_logger?.LogWarning($"The '{Alias}' feature filter is not valid for feature '{context.FeatureName}'. It must have have specify either '{nameof(settings.Start)}', '{nameof(settings.End)}', or both.");
5855

5956
return Task.FromResult(false);
6057
}

src/Microsoft.FeatureManagement/Targeting/TargetingFilter.cs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -64,10 +64,7 @@ public async Task<bool> EvaluateAsync(FeatureFilterEvaluationContext context)
6464
// Ensure targeting can be performed
6565
if (targetingContext == null)
6666
{
67-
if (_logger != null)
68-
{
69-
_logger.LogWarning("No targeting context available for targeting evaluation.");
70-
}
67+
_logger?.LogWarning("No targeting context available for targeting evaluation.");
7168

7269
return false;
7370
}

0 commit comments

Comments
 (0)