diff --git a/Textbook/src/DataDownload.py b/Textbook/src/DataDownload.py index a5aadb15..f8105c25 100644 --- a/Textbook/src/DataDownload.py +++ b/Textbook/src/DataDownload.py @@ -18,7 +18,29 @@ print("Extracting...") try: with tarfile.open(to_path) as file: - file.extractall(path = local) + + import os + + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(file, path=local) print("Done.") print("All Work Finished!") except: