This repository was archived by the owner on Dec 5, 2023. It is now read-only.
Socks to Sock #59
Merged
Socks to Sock #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Note that the logo in upper left corner is still "Socks Shop" on all of the deployment pages. Not sure where they pull in the logo from. I will submit pull request to change Socks Shop in the body of the Apcera page. I will also update the Apcera deployment files to match. |
Contributor
|
Perhaps the docs submodule under https://github.com/microservices-demo/microservices-demo has to be updated? |
Contributor
|
I filed the following pull requests to move to "Sock Shop": Note that I was very comprehensive, changing everything to use singular "sock" in docs, in file names, and inside the files. It would be great if these could both be merged today or tomorrow. Thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change Socks Shop to Sock Shop per #57