Skip to content

Use navigator.clipboard API when available #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Use navigator.clipboard API when available #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 18 additions & 7 deletions src/js/components/CopyToClipboard.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,21 +25,32 @@ export default class extends React.PureComponent {
}
}

handleCopy = () => {
const container = document.createElement('textarea');
copyText = async (textToCopy) => {
if (navigator.clipboard) {
return await navigator.clipboard.writeText(textToCopy);
} else {
const container = document.createElement('textarea');
container.innerHTML = textToCopy;
document.body.appendChild(container);
container.select();
document.execCommand('copy');
document.body.removeChild(container);

}

Comment on lines +29 to +40
Copy link
Member

@Kikobeats Kikobeats Sep 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (navigator.clipboard) {
return await navigator.clipboard.writeText(textToCopy);
} else {
const container = document.createElement('textarea');
container.innerHTML = textToCopy;
document.body.appendChild(container);
container.select();
document.execCommand('copy');
document.body.removeChild(container);
}
return await navigator.clipboard.writeText(textToCopy);

I think it's ok to assume navigator.clipboard.writeText is there

compat is +90% https://caniuse.com/mdn-api_clipboard_writetext

Copy link
Contributor

@mbtools mbtools Sep 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree, but then you can just replace await copyText with await navigator.clipboard.writeText(textToCopy);

}

handleCopy = async () => {
const { clickCallback, src, namespace } = this.props;

container.innerHTML = JSON.stringify(
const textToCopy = JSON.stringify(
this.clipboardValue(src),
null,
' '
);

document.body.appendChild(container);
container.select();
document.execCommand('copy');
await copyText(textToCopy);

document.body.removeChild(container);

this.copiedTimer = setTimeout(() => {
this.setState({
Expand Down