Skip to content

Commit 340e5bb

Browse files
microbit-robertmicrobit-robert
authored
PWA functionality including offline mode (featured flagged) (#1170)
Notable behaviours: - Fallback to English when changing language offline (when the selected language assets aren’t cached). - Shows image placeholders for uncached images when offline. - The app will automatically trigger a page reload when it detects the service worker has been updated. The service worker is updated when any of the build assets are updated. There are two levels of feature gating: - It's only enabled for microbit-foundation builds to avoid others shipping it accidentally. You can change FEATURE_PWA in the build to change this. We're open to a better system of build-time feature flags if there's interest (at least allowing existing env vars to override would make sense). - There's a client side feature flag. You have to set this via `localStorage.setItem("flags", "pwa")` for now if you want to test an actual PWA install. We'll default that flag on to release to the beta after building more confidence internally. Known issues: - The app name is too long for the iOS home screen and is truncated by eliding the space between micro:bit and Python then a .... It works fine when you open it. We'll discuss whether it's reasonable to address this or live with it. It doesn't seem to be related to the colon in micro:bit and the user can customise the app name.
1 parent b727b8a commit 340e5bb

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

45 files changed

+2934
-174
lines changed

‎.github/workflows/build.yml‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,8 @@ jobs:
2424
STAGING_CLOUDFRONT_DISTRIBUTION_ID: E2ELTBTA2OFPY2
2525
REVIEW_CLOUDFRONT_DISTRIBUTION_ID: E3267W09ZJHQG9
2626
VITE_FOUNDATION_BUILD: ${{ github.repository_owner == 'microbit-foundation' }}
27+
# This feature is also controlled by a client-side feature flag that is disabled by default for the moment
28+
FEATURE_PWA: ${{ github.repository_owner == 'microbit-foundation' }}
2729

2830
steps:
2931
# Note: This workflow disables deployment steps and micro:bit branding installation on forks.

‎index.html‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,14 @@
33
<head>
44
<meta charset="utf-8" />
55
<link rel="icon" href="%BASE_URL%favicon.ico" />
6+
<link rel="apple-touch-icon" href="%BASE_URL%logo512.png" sizes="512x512" />
67
<meta name="viewport" content="width=device-width, initial-scale=1" />
78
<meta name="theme-color" content="#6c4bc1" />
89
<title>micro:bit Python Editor</title>
10+
<meta
11+
name="description"
12+
content="A Python Editor for the BBC micro:bit, built by the Micro:bit Educational Foundation and the global Python Community."
13+
/>
914
<meta property="og:title" content="micro:bit Python Editor" />
1015
<meta
1116
property="og:description"

‎lang/ui.ca.json‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -510,6 +510,10 @@
510510
"defaultMessage": "Has d'<link>actualitzar el teu microprogramari</link> abans de poder connectar amb aquesta micro:bit.",
511511
"description": "Text in the no micro:bit found dialog"
512512
},
513+
"offline-image-alt": {
514+
"defaultMessage": "Image unavailable offline",
515+
"description": "Alt text for an image placeholder when the user is offline"
516+
},
513517
"open-action": {
514518
"defaultMessage": "Obert",
515519
"description": "Open button text"

‎lang/ui.de.json‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -510,6 +510,10 @@
510510
"defaultMessage": "Du musst <link>die Firmware aktualisieren</link>, bevor eine Verbindung zu diesem micro:bit hergestellt werden kann.",
511511
"description": "Text in the no micro:bit found dialog"
512512
},
513+
"offline-image-alt": {
514+
"defaultMessage": "Image unavailable offline",
515+
"description": "Alt text for an image placeholder when the user is offline"
516+
},
513517
"open-action": {
514518
"defaultMessage": "Öffnen",
515519
"description": "Open button text"

‎lang/ui.en.json‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -511,6 +511,10 @@
511511
"defaultMessage": "You must <link>update your firmware before</link> you can connect to this micro:bit.",
512512
"description": "Text in the no micro:bit found dialog"
513513
},
514+
"offline-image-alt": {
515+
"defaultMessage": "Image unavailable offline",
516+
"description": "Alt text for an image placeholder when the user is offline"
517+
},
514518
"open-action": {
515519
"defaultMessage": "Open",
516520
"description": "Open button text"

‎lang/ui.es-es.json‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -510,6 +510,10 @@
510510
"defaultMessage": "Debes <link>actualizar el firmware</link> para poder conectar a este micro:bit.",
511511
"description": "Text in the no micro:bit found dialog"
512512
},
513+
"offline-image-alt": {
514+
"defaultMessage": "Image unavailable offline",
515+
"description": "Alt text for an image placeholder when the user is offline"
516+
},
513517
"open-action": {
514518
"defaultMessage": "Abrir",
515519
"description": "Open button text"

‎lang/ui.fr.json‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -510,6 +510,10 @@
510510
"defaultMessage": "Vous devez <link>mettre à jour le micrologiciel</link> avant de pouvoir vous connecter à ce micro:bit.",
511511
"description": "Text in the no micro:bit found dialog"
512512
},
513+
"offline-image-alt": {
514+
"defaultMessage": "Image unavailable offline",
515+
"description": "Alt text for an image placeholder when the user is offline"
516+
},
513517
"open-action": {
514518
"defaultMessage": "Ouvrir",
515519
"description": "Open button text"

‎lang/ui.ja.json‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -510,6 +510,10 @@
510510
"defaultMessage": "このmicro:bitに接続するには、<link>ファームウェアを更新</link>する必要があります。",
511511
"description": "Text in the no micro:bit found dialog"
512512
},
513+
"offline-image-alt": {
514+
"defaultMessage": "Image unavailable offline",
515+
"description": "Alt text for an image placeholder when the user is offline"
516+
},
513517
"open-action": {
514518
"defaultMessage": "開く",
515519
"description": "Open button text"

‎lang/ui.ko.json‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -510,6 +510,10 @@
510510
"defaultMessage": "이 micro:bit에 연결하기 전에 <link>펌웨어를 업데이트</link>해야 합니다.",
511511
"description": "Text in the no micro:bit found dialog"
512512
},
513+
"offline-image-alt": {
514+
"defaultMessage": "Image unavailable offline",
515+
"description": "Alt text for an image placeholder when the user is offline"
516+
},
513517
"open-action": {
514518
"defaultMessage": "열기",
515519
"description": "Open button text"

‎lang/ui.nl.json‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -510,6 +510,10 @@
510510
"defaultMessage": "Je moet <link>firmware updaten voordat</link> je verbinding kan maken met deze micro:bit.",
511511
"description": "Text in the no micro:bit found dialog"
512512
},
513+
"offline-image-alt": {
514+
"defaultMessage": "Image unavailable offline",
515+
"description": "Alt text for an image placeholder when the user is offline"
516+
},
513517
"open-action": {
514518
"defaultMessage": "Open",
515519
"description": "Open button text"

0 commit comments

Comments
 (0)