codal_app: Provide constants for setting microphone threshold.

Signed-off-by: Damien George <[email protected]>

Author: dpgeorge

src/codal_app/microbithal.h

@@ -91,6 +91,10 @@ extern "C" {
 #define MICROBIT_HAL_MICROPHONE_EVT_THRESHOLD_LOW   (1)
 #define MICROBIT_HAL_MICROPHONE_EVT_THRESHOLD_HIGH  (2)
 
+// Threshold kind, passed to microbit_hal_microphone_set_threshold().
+#define MICROBIT_HAL_MICROPHONE_SET_THRESHOLD_LOW   (0)
+#define MICROBIT_HAL_MICROPHONE_SET_THRESHOLD_HIGH  (1)
+
 #define MICROBIT_HAL_LOG_TIMESTAMP_NONE             (0)
 #define MICROBIT_HAL_LOG_TIMESTAMP_MILLISECONDS     (1)
 #define MICROBIT_HAL_LOG_TIMESTAMP_SECONDS          (10)

src/codal_app/microbithal_microphone.cpp

@@ -58,7 +58,7 @@ void microbit_hal_microphone_init(void) {
 void microbit_hal_microphone_set_threshold(int kind, int value) {
     value = (value - HAL_LEVEL_MIN) * CODAL_LEVEL_RANGE / HAL_LEVEL_RANGE + CODAL_LEVEL_MIN;
     value = min(max(value, CODAL_LEVEL_MIN), CODAL_LEVEL_MAX);
-    if (kind == 0) {
+    if (kind == MICROBIT_HAL_MICROPHONE_SET_THRESHOLD_LOW) {
         uBit.audio.level->setLowThreshold(value);
     } else {
         uBit.audio.level->setHighThreshold(value);

src/codal_port/microbit_microphone.c

@@ -85,9 +85,9 @@ STATIC mp_obj_t microbit_microphone_set_threshold(mp_obj_t self_in, mp_obj_t sou
     uint8_t sound = sound_event_from_obj(sound_in);
     int kind;
     if (sound == SOUND_EVENT_QUIET) {
-        kind = 0;
+        kind = MICROBIT_HAL_MICROPHONE_SET_THRESHOLD_LOW;
     } else if (sound == SOUND_EVENT_LOUD) {
-        kind = 1;
+        kind = MICROBIT_HAL_MICROPHONE_SET_THRESHOLD_HIGH;
     } else {
         mp_raise_ValueError(MP_ERROR_TEXT("invalid sound"));
     }