Another AudioBuffer to createBuffer swap

microbit-robert · microbit-robert · commit 18d21de824ae · 2024-02-19T16:33:19.000Z
diff --git a/src/board/audio/index.ts b/src/board/audio/index.ts
@@ -184,11 +184,8 @@ class BufferedAudio {
   }
 
   createBuffer(length: number) {
-    return new AudioBuffer({
-      sampleRate: this.sampleRate,
-      numberOfChannels: 1,
-      length,
-    });
+    // Use createBuffer instead of new AudioBuffer to support Safari 14.0.
+    return this.context.createBuffer(1, length, this.sampleRate);
   }
 
   writeData(buffer: AudioBuffer) {

Original file line number	Diff line number	Diff line change
`@@ -184,11 +184,8 @@ class BufferedAudio {`
`184`	`184`	`}`
`185`	`185`
`186`	`186`	`createBuffer(length: number) {`
`187`		`- return new AudioBuffer({`
`188`		`- sampleRate: this.sampleRate,`
`189`		`- numberOfChannels: 1,`
`190`		`- length,`
`191`		`- });`
	`187`	`+ // Use createBuffer instead of new AudioBuffer to support Safari 14.0.`
	`188`	`+ return this.context.createBuffer(1, length, this.sampleRate);`
`192`	`189`	`}`
`193`	`190`
`194`	`191`	`writeData(buffer: AudioBuffer) {`