Escape feedback char in _else data. #344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackwinter
changed the base branch from
master
to
issue-338-else-nested-preserve-same-entity
fsteeg
approved these changes
Nov 26, 2020
Member
fsteeg
left a comment
fsteeg
left a comment
There was a problem hiding this comment.
Nice, thanks! I'll leave it for you to merge as you prefer.
One minor thought: maybe we should rename isFeedbackChar -> startsWithFeedbackChar
Note to self: I should adopt this approach instead of metafacture/metafacture-fix@f4dc31d
E.g. JSON-LD keywords. Fixes #343.
blackwinter
force-pushed
the
343-keywordsElse
branch
from
c59096a to
15c29d9
Compare
fsteeg
added a commit
to metafacture/metafacture-fix
that referenced
this pull request
Dec 1, 2020
fsteeg
added a commit
to metafacture/metafacture-fix
that referenced
this pull request
Dec 1, 2020
blackwinter
pushed a commit
that referenced
this pull request
Dec 13, 2024
- update metafacture-core dependency (#344) - increase version to 1.0.0 for the Java version is switched from 8 to 11.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass-through (
_else*) should bypass feedback/recursion mechanism.Fixes #343.
P.S.: I'd prefer the two commits to be squashed in order to provide a complete view of the issue (failing test + fix) and also have the tests passing for each individual commit.