Optim-wip: Fix duplicated target bug (#919)

* Fix duplicated target bug

* Fix duplicated target bug in `sum_loss_list` & `collect_activations`

* Add ToDo comment for target handling

Author: ProGamerGov

captum/optim/_core/loss.py

@@ -126,9 +126,14 @@ def loss_fn(module: ModuleOutputMapping) -> torch.Tensor:
             return math_op(torch.mean(self(module)), torch.mean(other(module)))
 
         name = f"Compose({', '.join([self.__name__, other.__name__])})"
+
+        # ToDo: Refine logic for self.target handling
         target = (self.target if isinstance(self.target, list) else [self.target]) + (
             other.target if isinstance(other.target, list) else [other.target]
         )
+
+        # Filter out duplicate targets
+        target = list(dict.fromkeys(target))
     else:
         raise TypeError(
             "Can only apply math operations with int, float or Loss. Received type "
@@ -875,6 +880,9 @@ def loss_fn(module: ModuleOutputMapping) -> torch.Tensor:
         ]
         for target in targets
     ]
+
+    # Filter out duplicate targets
+    target = list(dict.fromkeys(target))
     return CompositeLoss(loss_fn, name=name, target=target)
 
 

captum/optim/models/_common.py

@@ -255,6 +255,7 @@ def collect_activations(
     """
     if not isinstance(targets, list):
         targets = [targets]
+    targets = list(dict.fromkeys(targets))
     catch_activ = ActivationFetcher(model, targets)
     activ_dict = catch_activ(model_input)
     return activ_dict