Skip to content

Conversation

@banpei-dbart
Copy link

Adding listing, viewing and downloading of recordings as described in GROW-1083

@Ali-BenZarrouk-MB
Copy link

Ali-BenZarrouk-MB commented Aug 8, 2019

There are no unit tests. Consider adding the needed ones python-rest-api/tests/. And as an extra optional point if you feel like, fail the build if unit test coverage is less than the latest green build :).

@banpei-dbart
Copy link
Author

There are no unit tests. Consider adding the needed ones python-rest-api/tests/. And as an extra optional point if you feel like, fail the build if unit test coverage is less than the latest green build :).

I have added unit tests for most of my code (download can't be tested as it's difficult to mock) and tried to add code coverage. I did manage to change the unit tests to pytest and include coverage, but this lead to a dependency issue with pypy3.5, so that's on ignore for now.

For coverage checks: I tried to also pass the coverage to coveralls, but this hasn't been set up for this repo. Any ideas how to proceed with this?

@dysosmus dysosmus merged commit adb6f21 into messagebird:master Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants