-
Notifications
You must be signed in to change notification settings - Fork 65
Adding listing, viewing and downloading of recordings #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There are no unit tests. Consider adding the needed ones |
I have added unit tests for most of my code (download can't be tested as it's difficult to mock) and tried to add code coverage. I did manage to change the unit tests to pytest and include coverage, but this lead to a dependency issue with pypy3.5, so that's on ignore for now. For coverage checks: I tried to also pass the coverage to coveralls, but this hasn't been set up for this repo. Any ideas how to proceed with this? |
Adding listing, viewing and downloading of recordings as described in GROW-1083