Skip to content

Commit e0e2582

Browse files
committed
fix mutable default value with sentinel
1 parent 2d373cf commit e0e2582

File tree

1 file changed

+14
-7
lines changed

1 file changed

+14
-7
lines changed

messagebird/client.py

Lines changed: 14 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,8 @@ def __init__(self, access_key):
3333
self.access_key = access_key
3434
self._supported_status_codes = [200, 201, 204, 401, 404, 405, 422]
3535

36-
def request(self, path, method='GET', params={}):
36+
def request(self, path, method='GET', params=None):
37+
if params is None: params = {}
3738
url = urljoin(ENDPOINT, path)
3839

3940
headers = {
@@ -74,8 +75,9 @@ def message(self, id):
7475
"""Retrieve the information of a specific message."""
7576
return Message().load(self.request('messages/' + str(id)))
7677

77-
def message_create(self, originator, recipients, body, params={}):
78+
def message_create(self, originator, recipients, body, params=None):
7879
"""Create a new message."""
80+
if params is None: params = {}
7981
if type(recipients) == list:
8082
recipients = ','.join(recipients)
8183

@@ -86,32 +88,37 @@ def voice_message(self, id):
8688
"Retrieve the information of a specific voice message."
8789
return VoiceMessage().load(self.request('voicemessages/' + str(id)))
8890

89-
def voice_message_create(self, recipients, body, params={}):
91+
def voice_message_create(self, recipients, body, params=None):
9092
"""Create a new voice message."""
93+
if params is None: params = {}
9194
if type(recipients) == list:
9295
recipients = ','.join(recipients)
9396

9497
params.update({ 'recipients' : recipients, 'body' : body })
9598
return VoiceMessage().load(self.request('voicemessages', 'POST', params))
9699

97-
def lookup(self, phonenumber, params={}):
100+
def lookup(self, phonenumber, params=None):
98101
"""Do a new lookup."""
102+
if params is None: params = {}
99103
return Lookup().load(self.request('lookup/' + str(phonenumber), 'GET', params))
100104

101-
def lookup_hlr(self, phonenumber, params={}):
105+
def lookup_hlr(self, phonenumber, params=None):
102106
"""Retrieve the information of a specific HLR lookup."""
107+
if params is None: params = {}
103108
return HLR().load(self.request('lookup/' + str(phonenumber) + '/hlr', 'GET', params))
104109

105-
def lookup_hlr_create(self, phonenumber, params={}):
110+
def lookup_hlr_create(self, phonenumber, params=None):
106111
"""Perform a new HLR lookup."""
112+
if params is None: params = {}
107113
return HLR().load(self.request('lookup/' + str(phonenumber) + '/hlr', 'POST', params))
108114

109115
def verify(self, id):
110116
"""Retrieve the information of a specific verification."""
111117
return Verify().load(self.request('verify/' + str(id)))
112118

113-
def verify_create(self, recipient, params={}):
119+
def verify_create(self, recipient, params=None):
114120
"""Create a new verification."""
121+
if params is None: params = {}
115122
params.update({ 'recipient' : recipient })
116123
return Verify().load(self.request('verify', 'POST', params))
117124

0 commit comments

Comments
 (0)