Skip to content

Commit 7427024

Browse files
author
Arjen
committed
Removed Message().load(...) and added an error case test.
1 parent 39893c5 commit 7427024

File tree

2 files changed

+11
-2
lines changed

2 files changed

+11
-2
lines changed

messagebird/client.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ def message_create(self, originator, recipients, body, params=None):
9090

9191
def message_delete(self, id):
9292
"""Delete a message from the dashboard."""
93-
return Message().load(self.request('messages/' + str(id), 'DELETE'))
93+
self.request_plain_text('messages/' + str(id), 'DELETE')
9494

9595
def voice_message(self, id):
9696
"Retrieve the information of a specific voice message."

tests/test_message.py

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import unittest
2-
from messagebird import Client
2+
from messagebird import Client, ErrorException
33

44
try:
55
from unittest.mock import Mock
@@ -36,3 +36,12 @@ def test_message_delete(self):
3636
Client('', http_client).message_delete('message-id')
3737

3838
http_client.request.assert_called_once_with('messages/message-id', 'DELETE', None)
39+
40+
def test_message_delete_invalid(self):
41+
http_client = Mock()
42+
http_client.request.return_value = '{"errors": [{"code": 20, "description": "message not found", "parameter": null}]}'
43+
44+
with self.assertRaises(ErrorException):
45+
Client('', http_client).message_delete('non-existent-message-id')
46+
47+
http_client.request.assert_called_once_with('messages/non-existent-message-id', 'DELETE', None)

0 commit comments

Comments
 (0)