Fixes in tests and voice webhook class for consistency

Author: [email protected]

examples/voice_create_webhook.py

@@ -21,8 +21,8 @@
     print('  id                 : {}'.format(webhook.id))
     print('  token              : {}'.format(webhook.token))
     print('  url                : {}'.format(webhook.url))
-    print('  createdAtDatetime  : {}'.format(webhook.createdDatetime))
-    print('  updatedAtDatetime  : {}'.format(webhook.updatedDatetime))
+    print('  createdAt          : {}'.format(webhook.createdAt))
+    print('  updatedAt          : {}'.format(webhook.updatedAt))
 
 except messagebird.client.ErrorException as e:
     print('An error occured while creating a Voice Webhook object:')

examples/voice_list_webhook.py

@@ -24,8 +24,8 @@
         print('  id                 : {}'.format(webhook.id))
         print('  token              : {}'.format(webhook.token))
         print('  url                : {}'.format(webhook.url))
-        print('  createdAtDatetime  : {}'.format(webhook.createdDatetime))
-        print('  updatedAtDatetime  : {}'.format(webhook.updatedDatetime))
+        print('  createdAt          : {}'.format(webhook.createdAt))
+        print('  updatedAt          : {}'.format(webhook.updatedAt))
         print('}\n')
 
 except messagebird.client.ErrorException as e:

examples/voice_read_webhook.py

@@ -20,8 +20,8 @@
     print('  id                 : {}'.format(webhook.id))
     print('  token              : {}'.format(webhook.token))
     print('  url                : {}'.format(webhook.url))
-    print('  createdAtDatetime  : {}'.format(webhook.createdDatetime))
-    print('  updatedAtDatetime  : {}'.format(webhook.updatedDatetime))
+    print('  createdAt          : {}'.format(webhook.createdAt))
+    print('  updatedAt          : {}'.format(webhook.updatedAt))
 
 
 except messagebird.client.ErrorException as e:

examples/voice_update_webhook.py

@@ -22,8 +22,8 @@
     print('  id                 : {}'.format(webhook.id))
     print('  token              : {}'.format(webhook.token))
     print('  url                : {}'.format(webhook.url))
-    print('  createdAtDatetime  : {}'.format(webhook.createdDatetime))
-    print('  updatedAtDatetime  : {}'.format(webhook.updatedDatetime))
+    print('  createdAt          : {}'.format(webhook.createdAt))
+    print('  updatedAt          : {}'.format(webhook.updatedAt))
 
 except messagebird.client.ErrorException as e:
     print('An error occured while updating a Voice Webhook object:')

messagebird/error.py

@@ -11,12 +11,7 @@ def __str__(self):
         return str(dict(code=self.code, description=self.description, parameter=self.parameter))
 
 
-class BaseError(Exception):
-    """Base class for exceptions in this module."""
-    pass
-
-
-class ValidationError(BaseError):
+class ValidationError(ValueError):
     """Exception raised for errors in validation.
 
     Attributes:

messagebird/voice_webhook.py

@@ -7,27 +7,27 @@ def __init__(self):
         self.id = None
         self.url = None
         self.token = None
-        self._createdDatetime = None
-        self._updatedDatetime = None
+        self._createdAtDatetime = None
+        self._updatedAtDatetime = None
         self._links = None
 
     @property
-    def createdDatetime(self):
-        return self._createdDatetime
+    def createdAtDatetime(self):
+        return self._createdAtDatetime
 
-    @createdDatetime.setter
+    @createdAtDatetime.setter
     def createdAt(self, value):
         if value is not None:
-            self._createdDatetime = self.value_to_time(value, '%Y-%m-%dT%H:%M:%SZ')
+            self._createdAtDatetime = self.value_to_time(value, '%Y-%m-%dT%H:%M:%SZ')
 
     @property
-    def updatedDatetime(self):
-        return self._updatedDatetime
+    def updatedAtDatetime(self):
+        return self._updatedAtDatetime
 
-    @updatedDatetime.setter
+    @updatedAtDatetime.setter
     def updatedAt(self, value):
         if value is not None:
-            self._updatedDatetime = self.value_to_time(value, '%Y-%m-%dT%H:%M:%SZ')
+            self._updatedAtDatetime = self.value_to_time(value, '%Y-%m-%dT%H:%M:%SZ')
 
     def load(self, data):
         if data.get('data') is not None:
@@ -46,8 +46,8 @@ def __str__(self):
             'webhook id         : %s' % self.id,
             'url                : %s' % self.url,
             'token              : %s' % self.token,
-            'created date time  : %s' % self._createdDatetime,
-            'updated date time  : %s' % self._updatedDatetime,
+            'createdAtDatetime  : %s' % self._createdAtDatetime,
+            'updatedAtDatetime  : %s' % self._updatedAtDatetime,
             'links              : %s' % self._links
         ])