Shareserver as url and expose list of known shareservers #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mddub
approved these changes
Jun 20, 2017
| private var token: String? | ||
|
|
||
| public init(username: String, password: String, shareServer:ShareServer=ShareServer.US) { | ||
| public init(username: String, password: String, shareServer:String=KnownShareServers.US.rawValue) { |
Owner
There was a problem hiding this comment.
nit: since the convenience initializer below has a default value for shareServer, I don't think there should be a default value here.
loudnate
pushed a commit
to loudnate/dexcom-share-client-swift
that referenced
this pull request
Dec 6, 2020
Finnish translations update
loudnate
pushed a commit
to loudnate/dexcom-share-client-swift
that referenced
this pull request
Dec 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After feedback from @ps2, make shareclient framework accept shareserver string parameter. Also expose a list og known shareservers