Skip to content

Commit 89b47d5

Browse files
AbdeMohlbimboetger
authored andcommitted
remove x86 in BUILD.gn (flutter#170965)
based on [this comment](flutter#170191 (review)) Towards flutter#170142 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] All existing and new tests are passing. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
1 parent 34b021a commit 89b47d5

File tree

1 file changed

+0
-17
lines changed
  • engine/src/build/toolchain/linux

1 file changed

+0
-17
lines changed

engine/src/build/toolchain/linux/BUILD.gn

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -134,23 +134,6 @@ gcc_toolchain("clang_x86") {
134134
is_clang = true
135135
}
136136

137-
gcc_toolchain("x86") {
138-
prefix = ""
139-
asm = "${prefix}gcc"
140-
cc = "${compiler_prefix}${prefix}gcc"
141-
cxx = "${compiler_prefix}${prefix}g++"
142-
143-
readelf = "${prefix}readelf"
144-
nm = "${prefix}nm"
145-
ar = "${prefix}ar"
146-
ld = "${link_prefix}${prefix}g++"
147-
strip = "${prefix}strip"
148-
149-
toolchain_cpu = "x86"
150-
toolchain_os = "linux"
151-
is_clang = false
152-
}
153-
154137
gcc_toolchain("clang_x64") {
155138
prefix = rebased_clang_dir
156139
asm = "${prefix}/clang"

0 commit comments

Comments
 (0)